Skip to content

fix: Vue 2.7 using incorrect directive API #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2022

Conversation

nicholas-ramsey
Copy link
Contributor

This is a quick fix for Vue 2.7, which exports markRaw but doesn't support Vue 3's directive structure (e.g. bind -> beforeMount).

For example,
https://codepen.io/nicholas-ramsey/pen/ExLELLb?editors=0010 - Vue 2.7 - Doesn't work
https://codepen.io/nicholas-ramsey/pen/qBYoYyK?editors=0010 - Vue 2.6 - Works

Thanks for your work on this awesome library. 👍

@pdanpdan pdanpdan merged commit 86ac7f4 into pdanpdan:main Sep 30, 2022
@pdanpdan
Copy link
Owner

Thank you, it'll be fixed in next version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants