Skip to content

Conversation

pcriadoperez
Copy link
Owner

@pcriadoperez pcriadoperez commented Feb 22, 2025

Steps before merging PR

  • Make an account in codspeed (https://codspeed.io/) (It's free for public repos)
  • Save token in github secrets

Copy link

codspeed-hq bot commented Feb 22, 2025

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 1 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

  • test_benchmark_ws_api_order_book (29.6 µs)

Comment on lines 68 to 72
- name: Run benchmarks
uses: CodSpeedHQ/action@v3
with:
token: ${{ secrets.CODSPEED_TOKEN }}
run: pytest tests/ --codspeed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pcriadoperez, I am a co-founder @CodSpeedHQ.

I took a look at your setup with CodSpeed, and saw that you are using matrices
It means that for each run of the workflow, there will be multiple uploads of the same benchmarks, which is currently not supported by CodSpeed.

I greatly recommend that you upload only once per workflow, and if possible with the latest python version (3.12), so that you can benefit from automated flamegraphs.

This should do the trick:

Suggested change
- name: Run benchmarks
uses: CodSpeedHQ/action@v3
with:
token: ${{ secrets.CODSPEED_TOKEN }}
run: pytest tests/ --codspeed
- name: Run benchmarks
if: ${{ matrix.python == '3.12' }}
uses: CodSpeedHQ/action@v3
with:
token: ${{ secrets.CODSPEED_TOKEN }}
run: pytest tests/ --codspeed

@pcriadoperez
Copy link
Owner Author

@adriencaccia thanks for the comment! I closed this PR to open this one that contributes to the main repo: sammchardy#1564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants