Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement save #42

Closed
gtache opened this issue Feb 7, 2020 · 0 comments · Fixed by #43
Closed

Implement save #42

gtache opened this issue Feb 7, 2020 · 0 comments · Fixed by #43
Labels
Core Core rendering mdodule

Comments

@gtache
Copy link
Contributor

gtache commented Feb 7, 2020

It's just a proposition, but I think the default save (and the save button), with Ctrl+S, should save to the same filename. Save As (Ctrl+Shift+S) should obviously stay as is.
gtache added a commit to gtache/icepdf that referenced this issue Feb 7, 2020
@gtache
pcorlessGH-42 Implements save with same name on Ctrl+S
572c514
@gtache gtache mentioned this issue Feb 7, 2020
Merged
@pcorless pcorless added the Core Core rendering mdodule label Feb 12, 2020
@pcorless pcorless added this to the 6.5.0 milestone Feb 12, 2020
gtache added a commit to gtache/icepdf that referenced this issue Feb 12, 2020
@gtache
pcorlessGH-42 Fixes conflicts
a5266d7
gtache added a commit to gtache/icepdf that referenced this issue Feb 14, 2020
@gtache
pcorlessGH-42 Fixes error on close if document is null
07516f7
gtache added a commit to gtache/icepdf that referenced this issue Jul 15, 2020
@gtache
pcorlessGH-42 Disable save menu item when document is closed
79f27e2
gtache added a commit to gtache/icepdf that referenced this issue Apr 16, 2021
@gtache
pcorlessGH-42 Fixes conflicts
d41f6e6
gtache added a commit to gtache/icepdf that referenced this issue Apr 16, 2021
@gtache
pcorlessGH-42 Fixes saveAs not saving changes
5084e22
gtache added a commit to gtache/icepdf that referenced this issue Apr 16, 2021
@gtache
pcorlessGH-42 Simplify isChange
1ce558c
gtache added a commit to gtache/icepdf that referenced this issue Apr 16, 2021
@gtache
pcorlessGH-42 Uses Map instead of HashMap
2867f7c
gtache added a commit to gtache/icepdf that referenced this issue Apr 16, 2021
@gtache
pcorlessGH-42 Adds getter for isNew
21e4c20
gtache added a commit to gtache/icepdf that referenced this issue Apr 16, 2021
@gtache
pcorlessGH-42 Fixes library getting the Change instance instead of th…
6f731d9 
…e Object
gtache added a commit to gtache/icepdf that referenced this issue Sep 27, 2021
@gtache
pcorlessGH-42 Fixes the temp save filename not working if the filenam…
f91c56b 
…e contains a '.'
pcorless added a commit that referenced this issue Feb 1, 2022
@gtache @pcorless
GH-42 Simple save function (#43)
f97b85b 
* GH-25 Don't ask the user to save if no changes have been made since last save

* GH-42 Implements save with same name on Ctrl+S

* Adds timer at document open to get initial changes

* Reverts pom.xml

* Fixes conflict with PropertiesManager renaming

* GH-42 Fixes error on close if document is null

* Reformats MessageBundles

* GH-25 Takes updated pobjects into account

* GH-42 Disable save menu item when document is closed

* GH-42 Fixes saveAs not saving changes

* GH-42 Simplify isChange

* GH-42 Uses Map instead of HashMap

* GH-42 Adds getter for isNew

* GH-42 Fixes library getting the Change instance instead of the Object

* GH-42 Fixes the temp save filename not working if the filename contains a '.'

Co-authored-by: Patrick Corless <pcorless@users.noreply.github.com>
pcorless pushed a commit that referenced this issue Feb 1, 2022
GH-42 move saved changes map into StateManager
88506a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Core Core rendering mdodule
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simple save function gtache/icepdf
2 participants
@pcorless @gtache