Skip to content

Assert Behavior on scraping wallet without transactions #30

Open
@XenonOrion

Description

@XenonOrion

in commit fb697e1 the following behavior was introduced:

# etherscan/utils/parsing.py 
assert status, f"{result} -- {message}"

to replace the UserWarning behavior:

#etherscan/utils/parsing.py 
warnings.warn(f"{result} -- {message}")

This has made the event of scraping an empty address, "aggressive" and forces downstream applications to catch a generic AssertionError, for this---in my case common---scenario. imho, getting an empty list back in case no records exist, is completely valid behavior?

Could you elaborate on why this behavior was chosen, and this change was made?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions