Repository navigation
feat(auth-curl): add --max-time / --connect-timeout passthrough to curl - #4
Merged
Merged
Conversation
…curl auth-curl advertises itself as "curl with automatic Chrome cookie authentication", so tools that generate invocations naturally assume it mirrors curl's common flags. Passing `auth-curl --max-time N` previously failed with "unknown option". Add `--max-time <seconds>` and the sibling `--connect-timeout <seconds>` options, validate they are positive numbers (clean non-zero exit on invalid input), and forward them into the underlying curl command. Documents both flags in --help examples and the README. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 26, 2026
# [1.2.0](v1.1.1...v1.2.0) (2026-07-26) ### Bug Fixes * **decryptor:** correct macOS v10 cookie decryption (wrong key + M130 domain hash) ([#3](#3)) ([f4f6ed5](f4f6ed5)) ### Features * **auth-curl:** add --max-time and --connect-timeout passthrough to curl ([#4](#4)) ([5e46715](5e46715)) * **auth-curl:** forward unknown curl flags to the underlying curl ([#6](#6)) ([6739734](6739734))
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
--max-time <seconds>(and the commonly-paired sibling--connect-timeout <seconds>) to theauth-curlcommand, passing the value straight through to the underlyingcurlinvocation.auth-curladvertises itself as "curl with automatic Chrome cookie authentication", so tools that generate invocations naturally assume it mirrors curl's common flags. Before this change,auth-curl --max-time 20 "URL"failed witherror: unknown option '--max-time'(exit 1).This unblocks generated
auth-curl --max-timecalls — context: a watchtell alarm checker generates such invocations and was erroring out.Changes
--max-time <seconds>and--connect-timeout <seconds>.--max-time notanumber) fails cleanly with a clear message and non-zero exit instead of passing garbage to curl.--max-time N/--connect-timeout Nare forwarded into the builtcurlArgs.--helpexamples and the README (auth-curl section + options table).tests/auth-curl.test.tsasserting--max-time 20appears in the built curl command, plus the sibling flag, absence, and invalid-input cases. Tests mock/inspect the built curl args — no live network or real cookies.Testing
npx jest— 39 tests pass (8 suites).tsc --noEmitclean;eslint0 errors (pre-existing warnings only).Notes
securityCI job (npm audit) may show red for an unrelated, known reason (tracked separately as cce-ci-audit-fix); thetestchecks must pass.🤖 Generated with Claude Code