Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMakeLists.txt wrong required version #2

Open
jquenee opened this issue Feb 2, 2020 · 0 comments
Open

CMakeLists.txt wrong required version #2

jquenee opened this issue Feb 2, 2020 · 0 comments

Comments

@jquenee
Copy link

jquenee commented Feb 2, 2020 •
edited
Loading

cmake_minimum_required(VERSION 3.4) => cmake_minimum_required(VERSION 3.12)
add_compile_definitions() was introduced in cmake 3.12

Caution this libopk version is compiled by https://github.com/OpenDingux/buildroot/blob/od-rs90/package/cmake/cmake.mk (version cmake 3.8).
A fix should be made too there.
SiarheiVolkau added a commit to SiarheiVolkau/libopk that referenced this issue Feb 7, 2021
@SiarheiVolkau
fix Build with cmake < 3.12
4c700e7 
`add_compile_definitions` appers in cmake 3.12 as mentioned in pcercuei#2.
The patch reverts to use `add_definitions` instead which is present since cmake 2.x versions.
Fixes pcercuei#2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jquenee