BLD: separate lightpath and lightpath[gui] subpackages#190
BLD: separate lightpath and lightpath[gui] subpackages#190tangkong merged 13 commits intopcdshub:masterfrom
Conversation
533a43e to
8331c69
Compare
conda-recipe/meta.yaml
Outdated
| - name: lightpath-base | ||
| build: | ||
| noarch: python | ||
| script: python -m pip install . -vv |
There was a problem hiding this comment.
| script: python -m pip install . -vv | |
| script: {{ PYTHON }} -m pip install . -vv |
I'll look for the docs on this
There was a problem hiding this comment.
There was a problem hiding this comment.
https://github.com/pcdshub/lightpath/actions/runs/10564732964/job/29267769359#step:12:49
Attempting to finalize metadata for lightpath-base
Error: Failed to render jinja template in /home/runner/work/lightpath/lightpath/conda-recipe/meta.yaml:
'PYTHON' is undefined
There was a problem hiding this comment.
There was a problem hiding this comment.
Maybe this was the warning shot that suggests that something deeper was wrong with the conda build process
There was a problem hiding this comment.
I see now that the recipes that do the *-base thing don't use {{ PYTHON }}, my bad for the red herring
|
After quite a bit of squinting at conda build logs, I've arrived at a point where the conda build step succeeds, but the test environment gets clobbered/lost and cannot be used for the rest of the test suite. This is despite the environment artifact being created and uploaded sensibly The changes to the pip-side of things have worked from the onset, and I think are good moving forward. A nearly identical recipe works on the |
|
adding We still lose the test_env folder though 😢 |
|
The remaining py311 failures come from pinning pytest<7.2.0, before this version it wasn't marked as noarch so the allowed versions are very pinned down |
|
Ah we unpinned this a while ago. This was from an era where pytest-qt wasn't compatible |
|
It's all GREEEN |
ZLLentz
left a comment
There was a problem hiding this comment.
This is a great split that will help a lot in various cases!
Description
Separates lightpath base and gui-related dependencies
lightpathandlightpath[gui]conda:I could not get conda builds working, we leave this split to the conda feedstocklightpath-baseandlightpath(includes gui)Motivation and Context
Lightpath keeps dragging qt dependencies along with it
How Has This Been Tested?
pip installs locally. Conda eventually, but let's see if CI takes
Where Has This Been Documented?
This PR