Conversation
…e, removed print statements
…d epicsArchChecker from engineering tools to hutch python. Had to change from epicsArchChecker to epicsArchChecker.py to get the module recognizable.
ZLLentz
requested changes
Mar 21, 2024
Member
ZLLentz
left a comment
There was a problem hiding this comment.
Hi, the core here is good. I pointed out a lot documentation issues (DOC) and typos, and a small number of important issues. I also had a some things that confused me (may or may not be issues) and a bunch of nitpicks.
Co-authored-by: Zachary Lentz <ZLLentz@users.noreply.github.com>
Co-authored-by: Zachary Lentz <ZLLentz@users.noreply.github.com>
Co-authored-by: Zachary Lentz <ZLLentz@users.noreply.github.com>
Co-authored-by: Zachary Lentz <ZLLentz@users.noreply.github.com>
Co-authored-by: Zachary Lentz <ZLLentz@users.noreply.github.com>
Co-authored-by: Zachary Lentz <ZLLentz@users.noreply.github.com>
ZLLentz
reviewed
Apr 3, 2024
Member
ZLLentz
left a comment
There was a problem hiding this comment.
This is clean- just one more documentation suggestion and a minor minor nitpick
…text for --cds-items argument.
ZLLentz
approved these changes
Apr 4, 2024
Member
ZLLentz
left a comment
There was a problem hiding this comment.
Re-running the failed job (looks like an intermittent cloud networking error)
Otherwise this looks great, marking as approved!
Member
|
OK I am going to merge this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have added several feature edits and a couple of new features. Changes are listed below:
function edit
update_file: feature that looks at the current hutches epicsArch file and compares it to the questionnaire. It looks for instances of duplicate PVs and if this occurs then it will take the alias from the questionnaire instance and replace it for the one in the local epicsArch file. If there is no existing archfile it will do the existing task of of pulling the questionnaire data into a fresh archfile.
--softlink: this feature gives the users to unlink the symbolic link to epicsArch_experiment_specific.txt. It then replaces that link to point to the archfile to the new experiment.
--level: this feature gives developers the ability to set a debugging level. This shows where the code faults in the case that it does.
--cds-items: this feature interacts with the Python Questionnaire Client, for a given run and experiment. It pulls all of the elements in the cds tab of the questionnaire in the form of a dictionary. From there is parses the dictionary for keys with the string "pcds-setup". It then sorts the keys by type and shows them in a PrettyTable output in the terminal.
--link-path: this allows the user to provide a custom filepath for creating softlinks. Defaults to /cds/group/pcds/dist/pds/{}/misc/.
I have also edited some of the test scripts to match the new method names. I have also skipped one of the test methods because the test is no longer representing the functionality of the method and interactive testing has been done on it.
Motivation and Context
This change helps to prevent duplicating PV entries across the arch files, ensures we have the most current information from the questionnaire, and gives us another option besides overwriting the current file. It also provides helper functions for tasks and provides developer tools for debugging in the case of errors.
How Has This Been Tested?
The majority of the testing has been done with the existing test scripts on the hutch python folder and for the methods that no longer help I have done some interactive testing.
Where Has This Been Documented?
(https://confluence.slac.stanford.edu/display/PCDS/Questionnaire+flight+rules)
This page is a WIP but will have descriptions and examples of how to use the new methods.
Pre-merge checklist
docs/pre-release-notes.shand created a pre-release documentation page