calling of epicsArchVerify broke, need to fix env #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZLLentz
reviewed
Nov 4, 2025
Comment on lines
+69
to
+71
| for hutch in LCLS2_HUTCHES: | ||
| if hutch in path.parts: | ||
| break |
Member
There was a problem hiding this comment.
If no hutch is found, this would default to the last hutch. Is that ok for this script?
Collaborator
Author
There was a problem hiding this comment.
Because I'm only entering this loop when we are supposed to use 'verify' as we have found to be an LCLS2 hutch via the is_lcls2 function before, we will find a hutch here. Admittedly, this is not pretty, but I could not figure out how to set 'hutch' in the is_lcls2 function.
ZLLentz
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
FOr LCLS2 hutches, epicsArchChecker is supposed to call the DAQ maintained script epicsArchVerify. While some functionality is duplicated, this is the way to ensure that the syntax is correct for the DAQ.
sourcing the environment that has the appropriate epicsArchVerify has changed. This pull request addresses this.
How Has This Been Tested?
run this on MFX, XCS & TMO epicsArchFiles.
Where Has This Been Documented?
here.