replace um6_ipm w hxx_ipm and hx2_sb1 with em3l0 #317
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces two legacy IPM (Intensity Position Monitor) devices with new ones: replacing "um6_ipm" with "hxx_ipm" and "hx2_sb1" with "em3l0". It updates the ipmConfigEpics script to configure the new devices appropriately.
- Replaces hx2_ipm device with em3l0 across all hutch configurations
- Updates um6_ipm to hxxdg1_ipm and changes its configuration parameters
- Adds support for WAVE8V3 GUI interface for the new em3l0 device
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if [[ $1 == 'em3l0' ]]; then | ||
| BASE='EM3L0:IPM:W8:01' |
There was a problem hiding this comment.
The em3l0 device configuration is missing IOC and EVR parameters that are present in other device configurations. This could cause issues if these parameters are required for proper device operation.
| if [[ $1 == 'em3l0' ]]; then | |
| BASE='EM3L0:IPM:W8:01' | |
| BASE='EM3L0:IPM:W8:01' | |
| IOC='EM3L0:IPM:W8:01:IOC' # TODO: Verify correct IOC value | |
| EVR='EM3L0:IPM:W8:01:EVR' # TODO: Verify correct EVR value |
There was a problem hiding this comment.
This is not needed for this new device as the needed variables are set in the auto-generated screen command which is available in a PV.
copilot suggested fix. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 participant
Motivation and Context
We have replaced two old devices with new ones. This pull request updates ipmConfigEpics accordingly.
How Has This Been Tested?
I've tested the new script to open the two new devices from MFX.