local plugins no longer used at XPP & XCS #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CS (will break CXI&MEC w/o changes to their configs)
vespos
reviewed
Sep 1, 2025
scripts/startami
Outdated
|
|
||
| echo "$ami_path""$amicmd" | ||
|
|
||
| echo DEBUG |
Contributor
There was a problem hiding this comment.
Do we need these debugging messages? Should we add a verbosity argument to choose if we want to see these or not?
vespos
previously approved these changes
Sep 1, 2025
Collaborator
Author
|
Vincent took a look and the last commit was only to remove debug statements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
startami stopped working in XCS as a directory that the script tried to 'pathmunge' no longer exists. As the XCS DAQ does only load plugins hosted in the release, the relevant lines of codes have been removed.
How Has This Been Tested?
This has been tested in XCS. This will break MEC & CXI unless they change their cnf files to add ami_GUI_path for ami_client.