Skip to content

Conversation

@ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented Jul 24, 2025

Description

  • Fix an issue where the imgr and iocmanager wrapper scripts didn't launch properly when any specific hutch was chosen.
    • Launching for "the current hutch I'm in" was unaffected.
  • Ensure hutch is lowercase

Motivation and Context

I'd previously missed this in my testing. Ilia was trying to use these as documented and ran into an issue where the parser was passing the hutch name twice to the underlying iocmanager parser.

In the future when everyone updates to the R3 series these scripts will want some revisions to simplify the handling even further.

How Has This Been Tested?

I re-ran these scripts as multiple hutches with various input arguments and everything behaved as expected.

Where Has This Been Documented?

Here only

@ZLLentz ZLLentz requested a review from a team as a code owner July 24, 2025 20:18
@ZLLentz
Copy link
Member Author

ZLLentz commented Jul 28, 2025

I promise this worked great in testing

@ZLLentz ZLLentz requested a review from tangkong July 28, 2025 23:20
@ZLLentz
Copy link
Member Author

ZLLentz commented Jul 28, 2025

I'd like to get this in alongside the other thing we want to tag today/tomorrow if possible

Copy link
Contributor

@tangkong tangkong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangkong
Copy link
Contributor

I saw this and had a moment of dejavu, but it turns out I had just peeked at the diff last week and not left a review

@ZLLentz
Copy link
Member Author

ZLLentz commented Jul 29, 2025

I'm planning to tag/release engineering tools tomorrow when I have more brainpower to announce the update from #311

@ZLLentz ZLLentz merged commit a7c5759 into pcdshub:master Jul 29, 2025
2 checks passed
@ZLLentz ZLLentz deleted the fix_iocmanager_hutch branch July 29, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants