Skip to content

Conversation

@KaushikMalapati
Copy link
Contributor

Description

  • Spaces between brackets and if condition
  • Using $() instead of `` notation
  • Removing the unused variable LCLS2
  • Quoting the variables SIT_ENV_DIR (a path), HUTCH, station (a number), and RUN (run number)
  • Disabling warning for indirect error code check, since the command executed depends on whether it's LCLS 1 or 2 and the hutch. I could have saved the command based on the branches taken and executed in the if statement to check the exit code directly, but chose not to.

Motivation and Context

How Has This Been Tested?

Where Has This Been Documented?

@KaushikMalapati KaushikMalapati requested a review from a team as a code owner July 24, 2025 19:30
@KaushikMalapati
Copy link
Contributor Author

Not sure how to test this or what a pedestal is in this context

@ZLLentz
Copy link
Member

ZLLentz commented Jul 24, 2025

The diff looks clean
This does something like take a daq run and save some configuration information, right? We'll need a real system to test on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants