Server stat expert edt #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZLLentz
approved these changes
Jul 18, 2025
Member
ZLLentz
left a comment
ZLLentz
left a comment
There was a problem hiding this comment.
The changes seem well-motivated to me and are strict improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request contains mostly changes to the 'expert' option of serverStat.
stopdaq had a few lines removed that were no longer necessary and makepeds_psana no longer requests 5 CPUs where 1 suffices.
Other minor changes to the information displayed have been added and three other minor changes to other script have been packaged
Motivation and Context
serverStat --expert
could lead to machines becoming unresponsive - which is not the expected behavior for a command that is simply supposed to show you some information about said server. The only recent change has been an update to the EDT code that was called to gain more information about those cards. Given that we have essentially discontinued the use of these cards, I have chosen to simple display that there is one.
How Has This Been Tested?
processed pedestals for the epixquad in MEC & the jungfrau 4M in MFX
ran serverStat ioc-xrt-rec06 expert without adverse effects
(host w/ EDT card)
Where Has This Been Documented?
here