Skip to content

Shellcheck motor info #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KaushikMalapati merged 5 commits into from
Jul 18, 2025
Merged

Shellcheck motor info #301

KaushikMalapati merged 5 commits into from
Jul 18, 2025

Conversation

@KaushikMalapati
Copy link
Contributor

@KaushikMalapati KaushikMalapati commented Jun 14, 2025

Description

  • Removed trailing whitespace
  • Using parameter expansion instead of sed to replace comma with space
  • disabling unused var warnings for START and TIME (supposedly to be used when the archiver option is implemented), and FIELD in case it's ever used
  • Handling unknown flags by exiting and showing usage
  • Removing unnecessary from $ from an arithmetic expression
  • Replacing legacy backticks with $(...)
  • Using -gt instead of > for arithmetic comparisons
  • Using -r to read ANSWER (yes or no from user input)
  • Quoting many vars - $1, MOTOR_PV, IOC_DIR, pv (in PVLIST), $2, field (in PVFIELDS), file (in files), currValN, autoVal, file_date, same_value_dat, hutch, ACTION, ADD_MOTOR_PV, newval, value_mot1, values. Most are PVs, filepaths, filenames, or numbers.

Motivation and Context

https://jira.slac.stanford.edu/browse/ECS-5216

How Has This Been Tested?

Interactively

(pcds-5.9.1) [kaushikm@psbuild-rhel7-01 scripts]$ ./motorInfo -h
./motorInfo <motor_pv> <motor_pv_2|autosave|archive|pmgr_diff|pmgr_save> [opt]

If given two motors, compare their settings
If given autosave as second argument, compare the current settings to the autosaved values: differences will be printed
If given archive, the archive values will be printed for the last week. If only the base PV is given, extra arguments will be needed

OPTIONS:
-h shows the usage information
-f fields to use as a comma separated list <default: use all autosave values>
-s start time for archiver info <YYYY/MM/DD HH:MM:SS>
-e end time for archiver info <YYYY/MM/DD HH:MM:SS>
(pcds-5.9.1) [kaushikm@psbuild-rhel7-01 scripts]$ echo $?
0
(pcds-5.9.1) [kaushikm@psbuild-rhel7-01 scripts]$ ./motorInfo -z
./motorInfo: illegal option -- z
Unknown flag used
./motorInfo <motor_pv> <motor_pv_2|autosave|archive|pmgr_diff|pmgr_save> [opt]

If given two motors, compare their settings
If given autosave as second argument, compare the current settings to the autosaved values: differences will be printed
If given archive, the archive values will be printed for the last week. If only the base PV is given, extra arguments will be needed

OPTIONS:
-h shows the usage information
-f fields to use as a comma separated list <default: use all autosave values>
-s start time for archiver info <YYYY/MM/DD HH:MM:SS>
-e end time for archiver info <YYYY/MM/DD HH:MM:SS>
(pcds-5.9.1) [kaushikm@psbuild-rhel7-01 scripts]$ echo $?
1
(pcds-5.9.1) [kaushikm@psbuild-rhel7-01 scripts]$ ./motorInfo CXI:DG3:MMS:01
./motorInfo <motor_pv> <motor_pv_2|autosave|archive|pmgr_diff|pmgr_save> [opt]

If given two motors, compare their settings
If given autosave as second argument, compare the current settings to the autosaved values: differences will be printed
If given archive, the archive values will be printed for the last week. If only the base PV is given, extra arguments will be needed

OPTIONS:
-h shows the usage information
-f fields to use as a comma separated list <default: use all autosave values>
-s start time for archiver info <YYYY/MM/DD HH:MM:SS>
-e end time for archiver info <YYYY/MM/DD HH:MM:SS>
(pcds-5.9.1) [kaushikm@psbuild-rhel7-01 scripts]$ ./motorInfo CXI:DG3:MMS:01 autosave
ls: cannot access /reg/d/iocData/ioc-cxi-dg3-ipm-ims/autosave/*sav_1*: No such file or directory
Looking at the autosave history for: CXI:DG3:MMS:01:CFG_FILE

Looking at the autosave history for: CXI:DG3:MMS:01:REV_MEANS

Looking at the autosave history for: CXI:DG3:MMS:01:FW_MEANS

Looking at the autosave history for: CXI:DG3:MMS:01.HCSV

Looking at the autosave history for: CXI:DG3:MMS:01.DLVL

Looking at the autosave history for: CXI:DG3:MMS:01.ESKL

Looking at the autosave history for: CXI:DG3:MMS:01.ERBL

Looking at the autosave history for: CXI:DG3:MMS:01.EGAG

Looking at the autosave history for: CXI:DG3:MMS:01.HOMD

Looking at the autosave history for: CXI:DG3:MMS:01.TWV

Looking at the autosave history for: CXI:DG3:MMS:01.HACC

Looking at the autosave history for: CXI:DG3:MMS:01.BACC

Looking at the autosave history for: CXI:DG3:MMS:01.ACCL

Looking at the autosave history for: CXI:DG3:MMS:01.HS

Looking at the autosave history for: CXI:DG3:MMS:01.BS

Looking at the autosave history for: CXI:DG3:MMS:01.S

Looking at the autosave history for: CXI:DG3:MMS:01.SMAX

Looking at the autosave history for: CXI:DG3:MMS:01.SBAS

Looking at the autosave history for: CXI:DG3:MMS:01.PREC

Looking at the autosave history for: CXI:DG3:MMS:01.PDBD

Looking at the autosave history for: CXI:DG3:MMS:01.RDBD

Looking at the autosave history for: CXI:DG3:MMS:01.RTRY

Looking at the autosave history for: CXI:DG3:MMS:01.HLM

Looking at the autosave history for: CXI:DG3:MMS:01.LLM

Looking at the autosave history for: CXI:DG3:MMS:01.DHLM

Looking at the autosave history for: CXI:DG3:MMS:01.DLLM

Looking at the autosave history for: CXI:DG3:MMS:01.HDST

Looking at the autosave history for: CXI:DG3:MMS:01.BDST

Looking at the autosave history for: CXI:DG3:MMS:01.HEGE

Looking at the autosave history for: CXI:DG3:MMS:01.HTYP

Looking at the autosave history for: CXI:DG3:MMS:01.FOFF

Looking at the autosave history for: CXI:DG3:MMS:01.OFF

Looking at the autosave history for: CXI:DG3:MMS:01.DIR

Looking at the autosave history for: CXI:DG3:MMS:01.ERES

Looking at the autosave history for: CXI:DG3:MMS:01.MRES

Looking at the autosave history for: CXI:DG3:MMS:01.SREV

Looking at the autosave history for: CXI:DG3:MMS:01.FREV

Looking at the autosave history for: CXI:DG3:MMS:01.UREV

Looking at the autosave history for: CXI:DG3:MMS:01.EGU

Looking at the autosave history for: CXI:DG3:MMS:01.MODE

Looking at the autosave history for: CXI:DG3:MMS:01.HC

Looking at the autosave history for: CXI:DG3:MMS:01.HCMX

Looking at the autosave history for: CXI:DG3:MMS:01.RC

Looking at the autosave history for: CXI:DG3:MMS:01.RCMX

Looking at the autosave history for: CXI:DG3:MMS:01.HT

Looking at the autosave history for: CXI:DG3:MMS:01.MT

Looking at the autosave history for: CXI:DG3:MMS:01.ME

Looking at the autosave history for: CXI:DG3:MMS:01.EL

Looking at the autosave history for: CXI:DG3:MMS:01.EE

Looking at the autosave history for: CXI:DG3:MMS:01.ERSV

Looking at the autosave history for: CXI:DG3:MMS:01.STSV

Looking at the autosave history for: CXI:DG3:MMS:01.SF

Looking at the autosave history for: CXI:DG3:MMS:01.SM

Looking at the autosave history for: CXI:DG3:MMS:01.LM

Looking at the autosave history for: CXI:DG3:MMS:01.PORT

Looking at the autosave history for: CXI:DG3:MMS:01.TYPE

(pcds-5.9.1) [kaushikm@psbuild-rhel7-01 scripts]$ ./motorInfo -f .EE,.SF CXI:DG3:MMS:01 autosave
ls: cannot access /reg/d/iocData/ioc-cxi-dg3-ipm-ims/autosave/*sav_1*: No such file or directory
Looking at the autosave history for: CXI:DG3:MMS:01.EE

Looking at the autosave history for: CXI:DG3:MMS:01.SF

(pcds-5.9.1) [kaushikm@psbuild-rhel7-01 scripts]$ ./motorInfo CXI:DG3:MMS:01 archive
Command-line archiver is not implemented yet
(pcds-5.9.1) [kaushikm@psbuild-rhel7-01 scripts]$ ./motorInfo CXI:DG3:MMS:01 CXI:DG3:MMS:02
MOTORS DIFF 2 CXI:DG3:MMS:02
Field :  CXI:DG3:MMS:01 -- CXI:DG3:MMS:02
:REV_MEANS :  X- --  - Y-
:FW_MEANS :  X+ --  - Y+
.HCSV :  5 --  - 20
.BACC :  0.1 --  - 0.0014
.ACCL :  0.1 --  - 0.0014
.HS :  2 --  - 0.4
.S :  0.125945 --  - 0.5
.SMAX :  2 --  - 1
.RDBD :  0.004 --  - 0.01
.HLM :  4 --  - 200
.LLM :  -4 --  - -200
.DHLM :  4 --  - 200
.DLLM :  -4 --  - -200
.BDST :  0 --  - -0.1
.HTYP :  N/A --  - E Mark
.FOFF :  Variable --  - Frozen
.ERES :  0.000387695 --  - 0.00244141
.MRES :  1.55078e-05 --  - 9.76563e-05
.UREV :  0.794 --  - 5
.HC :  5 --  - 20
.HCMX :  5 --  - 20
.RC :  50 --  - 75
.RCMX :  50 --  - 75
.SF :  1000 --  - 600
.PORT :  digi-cxi-28:2101 --  - digi-cxi-28:2102
.DESC :  DG3 IPM Diode X --  - DG3 IPM Diode Y

Where Has This Been Documented?

@KaushikMalapati KaushikMalapati requested a review from a team as a code owner June 14, 2025 18:08
@ZLLentz
Copy link
Member

ZLLentz commented Jun 16, 2025

The code changes look good, I'd like to see a test case where the autosave history gives a non-empty value. I'm also curious to see the pmgr_diff option still working.

silkenelson
silkenelson reviewed Jun 16, 2025
View reviewed changes
Copy link
Collaborator

@silkenelson silkenelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which autosave files to check is wrong (now). It is possible this code is just that old and sav_1 made sense then, but it does not make sense now.

@KaushikMalapati
Copy link
Contributor Author

KaushikMalapati commented Jul 17, 2025

I forgot to follow up on this, but it's up to date and autosave/pmgr are working now.

autosave, archive (not implemented), 2 PVs

(pcds-5.9.1) [kaushikm@psbuild-rhel7-01 scripts]$ ./motorInfo CXI:DG3:MMS:01 autosave
Looking at the autosave history for: CXI:DG3:MMS:01:CFG_FILE

Looking at the autosave history for: CXI:DG3:MMS:01:REV_MEANS

Looking at the autosave history for: CXI:DG3:MMS:01:FW_MEANS

Looking at the autosave history for: CXI:DG3:MMS:01.HCSV

Looking at the autosave history for: CXI:DG3:MMS:01.DLVL

Looking at the autosave history for: CXI:DG3:MMS:01.ESKL

Looking at the autosave history for: CXI:DG3:MMS:01.ERBL

Looking at the autosave history for: CXI:DG3:MMS:01.EGAG

Looking at the autosave history for: CXI:DG3:MMS:01.HOMD

Looking at the autosave history for: CXI:DG3:MMS:01.TWV
CXI:DG3:MMS:01.TWV current: 1 -- 5 at 220913-142358 , was same last: 220923-125813
CXI:DG3:MMS:01.TWV current: 1 -- 5 at 220913-142341 , was same last: 220923-125813
CXI:DG3:MMS:01.TWV current: 1 -- 0.5 at 211112-143302 , was same last: 220627-111124
CXI:DG3:MMS:01.TWV current: 1 -- 0.5 at 211111-181714 , was same last: 220627-111124
CXI:DG3:MMS:01.TWV current: 1 -- 0.5 at 211111-181539 , was same last: 220627-111124
CXI:DG3:MMS:01.TWV current: 1 -- 0.5 at 210922-171852 , was same last: 220627-111124
CXI:DG3:MMS:01.TWV current: 1 -- 0.5 at 210624-185556 , was same last: 220627-111124
CXI:DG3:MMS:01.TWV current: 1 -- 0.5 at 210614-195321 , was same last: 220627-111124
CXI:DG3:MMS:01.TWV current: 1 -- 0.5 at 210527-174530 , was same last: 220627-111124
CXI:DG3:MMS:01.TWV current: 1 -- 0.5 at 210525-112142 , was same last: 220627-111124
CXI:DG3:MMS:01.TWV current: 1 -- 0.5 at 210517-172849 , was same last: 220627-111124
CXI:DG3:MMS:01.TWV current: 1 -- 0.5 at 210423-092125 , was same last: 220627-111124
CXI:DG3:MMS:01.TWV current: 1 -- 0.5 at 210217-200816 , was same last: 220627-111124
CXI:DG3:MMS:01.TWV current: 1 -- 0.5 at 210119-131303 , was same last: 220627-111124
CXI:DG3:MMS:01.TWV current: 1 -- 0.5 at 201119-140530 , was same last: 220627-111124
CXI:DG3:MMS:01.TWV current: 1 -- 0.5 at 201021-145344 , was same last: 220627-111124
CXI:DG3:MMS:01.TWV current: 1 -- 0.5 at 201021-134958 , was same last: 220627-111124
CXI:DG3:MMS:01.TWV current: 1 -- 0.5 at 201020-134759 , was same last: 220627-111124

Looking at the autosave history for: CXI:DG3:MMS:01.HACC

Looking at the autosave history for: CXI:DG3:MMS:01.BACC

Looking at the autosave history for: CXI:DG3:MMS:01.ACCL

Looking at the autosave history for: CXI:DG3:MMS:01.HS

Looking at the autosave history for: CXI:DG3:MMS:01.BS

Looking at the autosave history for: CXI:DG3:MMS:01.S
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 240910-104706 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 240909-172112 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 240524-042544 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 240409-154618 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 240304-100038 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 240228-153322 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 240205-102023 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 240112-150049 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 231211-133040 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 230919-154810 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 230915-145628 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 230609-180854 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 230403-145517 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 230402-213825 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 230323-124359 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 230210-105913 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 230119-114838 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 230110-143811 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 221117-142719 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 221027-183248 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 221026-141128 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 220927-144226 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 220923-125813 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 220913-142358 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 220913-142341 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 220913-124413 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 220913-120233 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 220912-164741 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 220909-155153 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 220909-145929 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 220909-144935 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 220627-111124 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 211112-143302 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 211111-181714 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 211111-181539 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 210922-171852 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 210624-185556 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 210614-195321 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 210527-174530 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 210525-112142 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 210517-172849 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 210423-092125 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 210217-200816 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 210119-131303 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 201119-140530 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 201021-145344 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 201021-134958 , was same last: now
CXI:DG3:MMS:01.S current: 0.125945 -- 0.12594458438287 at 201020-134759 , was same last: now

Looking at the autosave history for: CXI:DG3:MMS:01.SMAX

Looking at the autosave history for: CXI:DG3:MMS:01.SBAS

Looking at the autosave history for: CXI:DG3:MMS:01.PREC

Looking at the autosave history for: CXI:DG3:MMS:01.PDBD

Looking at the autosave history for: CXI:DG3:MMS:01.RDBD

Looking at the autosave history for: CXI:DG3:MMS:01.RTRY

Looking at the autosave history for: CXI:DG3:MMS:01.HLM

Looking at the autosave history for: CXI:DG3:MMS:01.LLM

Looking at the autosave history for: CXI:DG3:MMS:01.DHLM

Looking at the autosave history for: CXI:DG3:MMS:01.DLLM

Looking at the autosave history for: CXI:DG3:MMS:01.HDST

Looking at the autosave history for: CXI:DG3:MMS:01.BDST

Looking at the autosave history for: CXI:DG3:MMS:01.HEGE

Looking at the autosave history for: CXI:DG3:MMS:01.HTYP
CXI:DG3:MMS:01.HTYP current: 0 '('N/A')' -- 1 at 211111-181714 , was same last: 211112-143302
CXI:DG3:MMS:01.HTYP current: 0 '('N/A')' -- 1 at 211111-181539 , was same last: 211112-143302
CXI:DG3:MMS:01.HTYP current: 0 '('N/A')' -- 1 at 210922-171852 , was same last: 211112-143302
CXI:DG3:MMS:01.HTYP current: 0 '('N/A')' -- 1 at 210624-185556 , was same last: 211112-143302
CXI:DG3:MMS:01.HTYP current: 0 '('N/A')' -- 1 at 210614-195321 , was same last: 211112-143302
CXI:DG3:MMS:01.HTYP current: 0 '('N/A')' -- 1 at 210527-174530 , was same last: 211112-143302
CXI:DG3:MMS:01.HTYP current: 0 '('N/A')' -- 1 at 210525-112142 , was same last: 211112-143302
CXI:DG3:MMS:01.HTYP current: 0 '('N/A')' -- 1 at 210517-172849 , was same last: 211112-143302
CXI:DG3:MMS:01.HTYP current: 0 '('N/A')' -- 1 at 210423-092125 , was same last: 211112-143302
CXI:DG3:MMS:01.HTYP current: 0 '('N/A')' -- 1 at 210217-200816 , was same last: 211112-143302
CXI:DG3:MMS:01.HTYP current: 0 '('N/A')' -- 1 at 210119-131303 , was same last: 211112-143302
CXI:DG3:MMS:01.HTYP current: 0 '('N/A')' -- 1 at 201119-140530 , was same last: 211112-143302
CXI:DG3:MMS:01.HTYP current: 0 '('N/A')' -- 1 at 201021-145344 , was same last: 211112-143302
CXI:DG3:MMS:01.HTYP current: 0 '('N/A')' -- 1 at 201021-134958 , was same last: 211112-143302
CXI:DG3:MMS:01.HTYP current: 0 '('N/A')' -- 1 at 201020-134759 , was same last: 211112-143302

Looking at the autosave history for: CXI:DG3:MMS:01.FOFF
CXI:DG3:MMS:01.FOFF current: 0 '('Variable')' -- 1 at 220909-155153 , was same last: 220912-164741
CXI:DG3:MMS:01.FOFF current: 0 '('Variable')' -- 1 at 220909-145929 , was same last: 220912-164741
CXI:DG3:MMS:01.FOFF current: 0 '('Variable')' -- 1 at 220909-144935 , was same last: 220912-164741
CXI:DG3:MMS:01.FOFF current: 0 '('Variable')' -- 1 at 220627-111124 , was same last: 220912-164741
CXI:DG3:MMS:01.FOFF current: 0 '('Variable')' -- 1 at 211112-143302 , was same last: 220912-164741
CXI:DG3:MMS:01.FOFF current: 0 '('Variable')' -- 1 at 211111-181714 , was same last: 220912-164741
CXI:DG3:MMS:01.FOFF current: 0 '('Variable')' -- 1 at 211111-181539 , was same last: 220912-164741
CXI:DG3:MMS:01.FOFF current: 0 '('Variable')' -- 1 at 210922-171852 , was same last: 220912-164741
CXI:DG3:MMS:01.FOFF current: 0 '('Variable')' -- 1 at 210624-185556 , was same last: 220912-164741
CXI:DG3:MMS:01.FOFF current: 0 '('Variable')' -- 1 at 210614-195321 , was same last: 220912-164741
CXI:DG3:MMS:01.FOFF current: 0 '('Variable')' -- 1 at 210527-174530 , was same last: 220912-164741
CXI:DG3:MMS:01.FOFF current: 0 '('Variable')' -- 1 at 210525-112142 , was same last: 220912-164741
CXI:DG3:MMS:01.FOFF current: 0 '('Variable')' -- 1 at 210517-172849 , was same last: 220912-164741
CXI:DG3:MMS:01.FOFF current: 0 '('Variable')' -- 1 at 210423-092125 , was same last: 220912-164741
CXI:DG3:MMS:01.FOFF current: 0 '('Variable')' -- 1 at 210217-200816 , was same last: 220912-164741
CXI:DG3:MMS:01.FOFF current: 0 '('Variable')' -- 1 at 210119-131303 , was same last: 220912-164741
CXI:DG3:MMS:01.FOFF current: 0 '('Variable')' -- 1 at 201119-140530 , was same last: 220912-164741
CXI:DG3:MMS:01.FOFF current: 0 '('Variable')' -- 1 at 201021-145344 , was same last: 220912-164741
CXI:DG3:MMS:01.FOFF current: 0 '('Variable')' -- 1 at 201021-134958 , was same last: 220912-164741
CXI:DG3:MMS:01.FOFF current: 0 '('Variable')' -- 1 at 201020-134759 , was same last: 220912-164741

Looking at the autosave history for: CXI:DG3:MMS:01.OFF

Looking at the autosave history for: CXI:DG3:MMS:01.DIR

Looking at the autosave history for: CXI:DG3:MMS:01.ERES
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 240910-104706 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 240909-172112 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 240524-042544 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 240409-154618 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 240304-100038 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 240228-153322 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 240205-102023 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 240112-150049 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 231211-133040 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 230919-154810 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 230915-145628 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 230609-180854 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 230403-145517 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 230402-213825 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 230323-124359 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 230210-105913 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 230119-114838 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 230110-143811 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 221117-142719 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 221027-183248 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 221026-141128 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 220927-144226 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 220923-125813 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 220913-142358 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 220913-142341 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 220913-124413 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 220913-120233 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 220912-164741 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 220909-155153 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 220909-145929 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 220909-144935 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 220627-111124 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 211112-143302 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 211111-181714 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 211111-181539 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 210922-171852 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 210624-185556 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 210614-195321 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 210527-174530 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 210525-112142 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 210517-172849 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 210423-092125 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 210217-200816 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 210119-131303 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 201119-140530 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 201021-145344 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 201021-134958 , was same last: now
CXI:DG3:MMS:01.ERES current: 0.000387695 -- 0.0003876953125 at 201020-134759 , was same last: now

Looking at the autosave history for: CXI:DG3:MMS:01.MRES
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 240910-104706 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 240909-172112 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 240524-042544 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 240409-154618 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 240304-100038 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 240228-153322 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 240205-102023 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 240112-150049 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 231211-133040 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 230919-154810 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 230915-145628 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 230609-180854 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 230403-145517 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 230402-213825 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 230323-124359 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 230210-105913 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 230119-114838 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 230110-143811 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 221117-142719 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 221027-183248 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 221026-141128 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 220927-144226 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 220923-125813 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 220913-142358 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 220913-142341 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 220913-124413 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 220913-120233 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 220912-164741 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 220909-155153 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 220909-145929 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 220909-144935 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 220627-111124 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 211112-143302 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 211111-181714 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 211111-181539 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 210922-171852 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 210624-185556 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 210614-195321 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 210527-174530 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 210525-112142 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 210517-172849 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 210423-092125 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 210217-200816 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 210119-131303 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 201119-140530 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 201021-145344 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 201021-134958 , was same last: now
CXI:DG3:MMS:01.MRES current: 1.55078e-05 -- 1.55078125e-05 at 201020-134759 , was same last: now

Looking at the autosave history for: CXI:DG3:MMS:01.SREV

Looking at the autosave history for: CXI:DG3:MMS:01.FREV

Looking at the autosave history for: CXI:DG3:MMS:01.UREV

Looking at the autosave history for: CXI:DG3:MMS:01.EGU

Looking at the autosave history for: CXI:DG3:MMS:01.MODE

Looking at the autosave history for: CXI:DG3:MMS:01.HC

Looking at the autosave history for: CXI:DG3:MMS:01.HCMX

Looking at the autosave history for: CXI:DG3:MMS:01.RC

Looking at the autosave history for: CXI:DG3:MMS:01.RCMX

Looking at the autosave history for: CXI:DG3:MMS:01.HT

Looking at the autosave history for: CXI:DG3:MMS:01.MT

Looking at the autosave history for: CXI:DG3:MMS:01.ME

Looking at the autosave history for: CXI:DG3:MMS:01.EL

Looking at the autosave history for: CXI:DG3:MMS:01.EE

Looking at the autosave history for: CXI:DG3:MMS:01.ERSV

Looking at the autosave history for: CXI:DG3:MMS:01.STSV

Looking at the autosave history for: CXI:DG3:MMS:01.SF
CXI:DG3:MMS:01.SF current: 1000 -- 600 at 220913-124413 , was same last: 220913-142341
CXI:DG3:MMS:01.SF current: 1000 -- 600 at 220913-120233 , was same last: 220913-142341
CXI:DG3:MMS:01.SF current: 1000 -- 600 at 220912-164741 , was same last: 220913-142341
CXI:DG3:MMS:01.SF current: 1000 -- 600 at 220909-155153 , was same last: 220913-142341
CXI:DG3:MMS:01.SF current: 1000 -- 600 at 220909-145929 , was same last: 220913-142341
CXI:DG3:MMS:01.SF current: 1000 -- 600 at 220909-144935 , was same last: 220913-142341
CXI:DG3:MMS:01.SF current: 1000 -- 600 at 220627-111124 , was same last: 220913-142341
CXI:DG3:MMS:01.SF current: 1000 -- 600 at 211112-143302 , was same last: 220913-142341
CXI:DG3:MMS:01.SF current: 1000 -- 600 at 211111-181714 , was same last: 220913-142341
CXI:DG3:MMS:01.SF current: 1000 -- 600 at 211111-181539 , was same last: 220913-142341
CXI:DG3:MMS:01.SF current: 1000 -- 600 at 210922-171852 , was same last: 220913-142341
CXI:DG3:MMS:01.SF current: 1000 -- 600 at 210624-185556 , was same last: 220913-142341
CXI:DG3:MMS:01.SF current: 1000 -- 600 at 210614-195321 , was same last: 220913-142341
CXI:DG3:MMS:01.SF current: 1000 -- 600 at 210527-174530 , was same last: 220913-142341
CXI:DG3:MMS:01.SF current: 1000 -- 600 at 210525-112142 , was same last: 220913-142341
CXI:DG3:MMS:01.SF current: 1000 -- 600 at 210517-172849 , was same last: 220913-142341
CXI:DG3:MMS:01.SF current: 1000 -- 600 at 210423-092125 , was same last: 220913-142341
CXI:DG3:MMS:01.SF current: 1000 -- 600 at 210217-200816 , was same last: 220913-142341
CXI:DG3:MMS:01.SF current: 1000 -- 600 at 210119-131303 , was same last: 220913-142341
CXI:DG3:MMS:01.SF current: 1000 -- 600 at 201119-140530 , was same last: 220913-142341
CXI:DG3:MMS:01.SF current: 1000 -- 600 at 201021-145344 , was same last: 220913-142341
CXI:DG3:MMS:01.SF current: 1000 -- 600 at 201021-134958 , was same last: 220913-142341
CXI:DG3:MMS:01.SF current: 1000 -- 600 at 201020-134759 , was same last: 220913-142341

Looking at the autosave history for: CXI:DG3:MMS:01.SM

Looking at the autosave history for: CXI:DG3:MMS:01.LM

Looking at the autosave history for: CXI:DG3:MMS:01.PORT

Looking at the autosave history for: CXI:DG3:MMS:01.TYPE

(pcds-5.9.1) [kaushikm@psbuild-rhel7-01 scripts]$ ./motorInfo CXI:DG3:MMS:01 archive
Command-line archiver is not implemented yet
(pcds-5.9.1) [kaushikm@psbuild-rhel7-01 scripts]$ ./motorInfo CXI:DG3:MMS:01 CXI:DG3:MMS:02
MOTORS DIFF 2 CXI:DG3:MMS:02
Field :  CXI:DG3:MMS:01 -- CXI:DG3:MMS:02
:REV_MEANS :  X- --  - Y-
:FW_MEANS :  X+ --  - Y+
.HCSV :  5 --  - 20
.BACC :  0.1 --  - 0.0014
.ACCL :  0.1 --  - 0.0014
.HS :  2 --  - 0.4
.S :  0.125945 --  - 0.5
.SMAX :  2 --  - 1
.RDBD :  0.004 --  - 0.01
.HLM :  4 --  - 200
.LLM :  -4 --  - -200
.DHLM :  4 --  - 200
.DLLM :  -4 --  - -200
.BDST :  0 --  - -0.1
.HTYP :  N/A --  - E Mark
.FOFF :  Variable --  - Frozen
.ERES :  0.000387695 --  - 0.00244141
.MRES :  1.55078e-05 --  - 9.76563e-05
.UREV :  0.794 --  - 5
.HC :  5 --  - 20
.HCMX :  5 --  - 20
.RC :  50 --  - 75
.RCMX :  50 --  - 75
.SF :  1000 --  - 600
.PORT :  digi-cxi-28:2101 --  - digi-cxi-28:2102
.DESC :  DG3 IPM Diode X --  - DG3 IPM Diode Y

pmgr_diff (I didn't realize you need to be on a hutch machine for pmgr to pick config)

[kaushikm@cxi-console scripts]$ ./motorInfo CXI:USR:MMS:19 pmgr_diff
Using production server.
Motor PV:          CXI:USR:MMS:19
Motor description: Pinhole Y
Differences for CXI:USR:MMS:19:
    FLD_DIR: actual=Neg, configured=Pos
    FLD_HDST: actual=5.0, configured=1.0
    FLD_RDBD: actual=0.001, configured=0.01
    FLD_RTRY: actual=10, configured=3
    FLD_TWV: actual=0.01, configured=10.0
    FLD_HS: actual=1.25, configured=2.0
    FLD_S: actual=2.5, configured=1.0

ZLLentz
ZLLentz approved these changes Jul 18, 2025
View reviewed changes
Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely fixes the sav bug and in general gets us in a good place with shellcheck, nice job

@KaushikMalapati KaushikMalapati merged commit 99a4e41 into pcdshub:master Jul 18, 2025
2 checks passed
@KaushikMalapati KaushikMalapati deleted the shellcheck-motorInfo branch July 18, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZLLentz ZLLentz ZLLentz approved these changes

@silkenelson silkenelson Awaiting requested review from silkenelson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KaushikMalapati @ZLLentz @silkenelson