Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example projects #43

Merged
merged 7 commits into from
Aug 26, 2024
Merged

Fix example projects #43

merged 7 commits into from
Aug 26, 2024

Conversation

BlastBrothers
Copy link
Contributor

There are still some issues that I haven't been able to pin down:

  • fileio has an issue with remove()
  • invaders is very broken. Crashes emulator and hardware. I added some (commented-out) debugging lines to try and isolate the problem - I don't even get that far on emulator, and on hardware it fails on a different line each time. Perhaps this one should just be replaced with a new example?

In addition, sprite, vdu, and invaders really should copy their associated graphics folders to /bin so they can run, but they don't do this currently.

@BlastBrothers
Copy link
Contributor Author

BlastBrothers commented Aug 24, 2024

  • Invaders is gone.
  • images needed for the examples to run are copied to /bin.
  • the issue with remove() is patched over by putting a declaration in fileio.c - I don't know why the compiler isn't picking up the one from stdio but that's a challenge for another day.

@BlastBrothers BlastBrothers marked this pull request as ready for review August 24, 2024 20:46
@BlastBrothers BlastBrothers changed the title Fix (most of the) example projects Fix example projects Aug 24, 2024
@astralaster astralaster force-pushed the fix-projects branch 3 times, most recently from 2030cf6 to acdce49 Compare August 26, 2024 20:38
Copy link
Collaborator

@astralaster astralaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some cleanups. Thanks for your contribution!

@astralaster astralaster merged commit 6b04434 into pcawte:main Aug 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants