feat: Option to not hash the salt #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xkowloon
force-pushed
the
feat/optional-salt-hash
branch
from
2770a72
to
9859751
Compare
|
@0xkowloon thanks for this PR. As discussed on GitHub we first discuss it here: #83. There are currently a couple of things missing:
My suggestion is that we first discuss this feature request and if we see enough people want this feature we can consider merging the PR. For the moment being I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Provide an option to use the salt provided as is instead of hashing the salt because xdeployer doesn't work in the case where the salt is found by a program to find gas-efficient contract addresses.