-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π₯ Implement ERC-1155 Standard Token #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
pcaversaccio
changed the title
π€ ERC-4626 Tokenised Vault Implementation
π€ ERC-1155 Token Implementation
Dec 19, 2022
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Co-authored-by: Pascal Marco Caversaccio <pcaversaccio@users.noreply.github.com> Signed-off-by: JT <Jtriley15@gmail.com>
Co-authored-by: Pascal Marco Caversaccio <pcaversaccio@users.noreply.github.com> Signed-off-by: JT <Jtriley15@gmail.com>
Co-authored-by: Pascal Marco Caversaccio <pcaversaccio@users.noreply.github.com> Signed-off-by: JT <Jtriley15@gmail.com>
Co-authored-by: Pascal Marco Caversaccio <pcaversaccio@users.noreply.github.com> Signed-off-by: JT <Jtriley15@gmail.com>
Co-authored-by: Pascal Marco Caversaccio <pcaversaccio@users.noreply.github.com> Signed-off-by: JT <Jtriley15@gmail.com>
Co-authored-by: Pascal Marco Caversaccio <pcaversaccio@users.noreply.github.com> Signed-off-by: JT <Jtriley15@gmail.com>
Co-authored-by: Pascal Marco Caversaccio <pcaversaccio@users.noreply.github.com> Signed-off-by: JT <Jtriley15@gmail.com>
Co-authored-by: Pascal Marco Caversaccio <pcaversaccio@users.noreply.github.com> Signed-off-by: JT <Jtriley15@gmail.com>
Co-authored-by: Pascal Marco Caversaccio <pcaversaccio@users.noreply.github.com> Signed-off-by: JT <Jtriley15@gmail.com>
`ERC1155MetadataURI` Implementation Logic
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
β¦ view Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
pcaversaccio
added
bug π
Something isn't working
optimisation β‘οΈ
Code optimisations (e.g. gas improvements)
labels
Jan 13, 2023
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
pcaversaccio
commented
Jan 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jtriley-eth LFG π₯³
pcaversaccio
changed the title
π€ ERC-1155 Token Implementation
π₯ Implement ERC-1155 Standard Token
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug π
Something isn't working
feature π₯
New feature or request
optimisation β‘οΈ
Code optimisations (e.g. gas improvements)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π§πΌββοΈ CHANGELOG
Closes #15. In addition to the standard
EIP-1155
functionalities, we implement the following features:Mintable
ERC1155Burnable
ERC1155URIStorage
ERC1155Supply
π¦ Bug Fixes
ERC20
,ERC721
, andERC1155
contracts, the missingRoleMinterChanged
event. Thanks, @jtriley-eth for pointing this out!_before_token_transfer
and_after_token_transfer
hooks & the missingTransfer
event in theERC20
constructor.to
toowner
due to the sake of consistency in theinternal
mint functions_safe_mint
and_mint
of theERC721
contract.IERC165
functionsupportsInterface
to the interfacesIERC1155
,IERC1155MetadataURI
,IERC1155Receiver
,IERC721Enumerable
,IERC721Metadata
, andIERC721Permit
. We also fix the correct visibility modifier from@pure
to@view
.transfer_ownership
andrenounce_ownership
in theERC20
,ERC721
, andERC1155
contracts in order to add missing events and automatically remove the previous owner's minter role and assign the minter role tonew_owner
accordingly.π Improved Documentation
We add missing EIP links to three
ERC721
interfaces:IERC721Enumerable
IERC721Receiver
IERC721Metadata
We add a note on return value bounds in Vyper interfaces to three interfaces where this is relevant:
IERC721Metadata
IERC1155MetadataURI
IERC1155
We add in the
ERC20
,ERC721
, andERC1155
contract documentation, which functions areview
functions.Fixes β»οΈ Reorder
README
SequenceΒ #48.π―ββοΈ Co-Author
Special thanks go to @jtriley-eth who co-authored this PR ππ½. He deserves the cheer!