Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Include Version and Configuration Information in Gas Snapshots #282

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

pcaversaccio
Copy link
Owner

@pcaversaccio pcaversaccio commented Oct 11, 2024

🕓 Changelog

This PR adds a Bash script, generate_gas_snapshot.sh, that includes version and configuration information into the gas snapshot files to improve traceability. Specifically, it prepends the vyper commit version, the forge commit version, and vyper configuration settings (e.g. optimisation mode) to the snapshot files. The script also supports generating snapshots for the default-venom profile using the --venom flag. Eventually, we pin the specific vyper commit d8f4032355773cd5e57e8902bd50808490de39b5 as the subsequent commit fdc05d6029816ef57294e98753d9a3d60c761ab8 (PR #4039) currently breaks our venom-based tests (refer to issue #4288 for details).

🐶 Cute Animal Picture

image

Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio pcaversaccio self-assigned this Oct 11, 2024
@pcaversaccio pcaversaccio added documentation 📖 Improvements or additions to documentation dependencies 🔁 Pull requests that update a dependency file labels Oct 11, 2024
@pcaversaccio pcaversaccio added this to the 0.1.1 milestone Oct 11, 2024
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio pcaversaccio added the ci/cd 👷‍♂️ CI/CD configurations label Oct 11, 2024
@pcaversaccio pcaversaccio merged commit 3b63a27 into main Oct 11, 2024
15 checks passed
@pcaversaccio pcaversaccio deleted the chore/gas-snapshot-commit-info branch October 11, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd 👷‍♂️ CI/CD configurations dependencies 🔁 Pull requests that update a dependency file documentation 📖 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant