Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💥 Add ERC-2981 Implementation #138

Merged
merged 25 commits into from
Jun 23, 2023
Merged

💥 Add ERC-2981 Implementation #138

merged 25 commits into from
Jun 23, 2023

Conversation

pcaversaccio
Copy link
Owner

@pcaversaccio pcaversaccio commented Jun 19, 2023 •
edited
Loading

🕓 CHANGELOG

This PR adds an ERC-721 and ERC-1155 compatible ERC-2981 reference implementation (closes #120). Unit, fuzzing, and invariant tests have been added as part of the test suite.

Further changes include:

  • Enhance --white-list option in awesome_bot of CI check checks.yml (7aa3bdf);
  • Use tokenId instead of token_id in interface definitions to be consistent with the official EIP-165 specification (9cb9303);
  • Add note on stand-alone usage of the interfaces IERC1155MetadataURI, IERC4906, IERC721Enumerable, and IERC721Metadata (6ae3c0d);
  • We bump @openzeppelin/merkle-tree to version 1.0.5 (d25d4cd);

🐶 Cute Animal Picture

image

@pcaversaccio
📖 Add README and CHANGELOG entries
167ee57 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio pcaversaccio added the feature 💥 New feature or request label Jun 19, 2023
@pcaversaccio pcaversaccio added this to the 0.0.3 milestone Jun 19, 2023
@pcaversaccio pcaversaccio self-assigned this Jun 19, 2023
@pcaversaccio
👷‍♂️ Enhance white-list in awesome_bot
7aa3bdf 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio pcaversaccio added the ci/cd 👷‍♂️ CI/CD configurations label Jun 19, 2023
@pcaversaccio
🔁 Use official param naming in interface definitions
9cb9303 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio
♻️ IERC2981 interface
88c3150 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio
♻️ IERC2981 interface wording
aecdf79 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio
📖 Add note on interface usage for ERC721 and ERC1155
6ae3c0d 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio pcaversaccio added the refactor/cleanup ♻️ Code refactorings and cleanups label Jun 19, 2023
@pcaversaccio
💥 ERC2981 Implementation
2603649 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio
🔁 Bump Submodules
2779b72 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio pcaversaccio changed the title 💥 Add ERC-2981 (NFT Royalty Standard) Implementation 💥 Add ERC-2981 Implementation Jun 19, 2023
pcaversaccio and others added 7 commits June 20, 2023 09:34
@pcaversaccio
Merge branch 'main' into erc2981
a1a3bc9
@pcaversaccio
♻️ Wording
318c13c 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio
♻️ warning on default values
c36c0c5 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio
♻️ Add IERC2981Extended test interface
276228c 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio
💥 ERC2981 unit tests
c56d689 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio
💥 ERC2981 fuzz tests
41f85f6 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio
💥 ERC2981 invariant tests
7ee6a4d 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio pcaversaccio marked this pull request as ready for review June 20, 2023 12:37
@pcaversaccio
🔁 Bump Submodules
659c6ad 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio
♻️ singular wording
060fdeb 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio
♻️ code chore
6972c0f 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio
♻️ add gas-snapshot
6b0a029 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
pcaversaccio
pcaversaccio commented Jun 21, 2023
View reviewed changes
Copy link
Owner Author

@pcaversaccio pcaversaccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed some final fixes and we're good to go imo. Now waiting for final feedback from @victor-ego before merging.

@pcaversaccio
♻️ fix link
cfdee42 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio
🔁 Bump submodules
d41882f 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio
🔁 Bump submodules
6afbd3e 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio
🔁 Bump @openzeppelin/merkle-tree
d25d4cd 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio
🔁 Bump Submodules
1c7989e 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio
♻️ fix failing test
56c7c68 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio pcaversaccio merged commit 1196d49 into main Jun 23, 2023
@pcaversaccio pcaversaccio deleted the erc2981 branch June 23, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcaversaccio pcaversaccio

Labels
ci/cd 👷‍♂️ CI/CD configurations feature 💥 New feature or request refactor/cleanup ♻️ Code refactorings and cleanups
Projects
None yet
Milestone
0.0.3
Development

Successfully merging this pull request may close these issues.

💥 ERC-2981 (NFT Royalty Standard) Implementation
1 participant
@pcaversaccio