Skip to content

Commit

Permalink
Increase min version for sparse_checkout (spack#45818)
Browse files Browse the repository at this point in the history
* Increase min version for sparse_checkout

* Update git_fetch.py

* style
  • Loading branch information
psakievich authored Aug 20, 2024
1 parent 2ae5596 commit 8590595
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion lib/spack/spack/fetch_strategy.py
Original file line number Diff line number Diff line change
Expand Up @@ -930,7 +930,9 @@ def _sparse_clone_src(self, commit=None, branch=None, tag=None, **kwargs):
dest = self.stage.source_path
git = self.git

if self.git_version < spack.version.Version("2.25.0.0"):
if self.git_version < spack.version.Version("2.26.0"):
# technically this should be supported for 2.25, but bumping for OS issues
# see https://github.com/spack/spack/issues/45771
# code paths exist where the package is not set. Assure some indentifier for the
# package that was configured for sparse checkout exists in the error message
identifier = str(self.url)
Expand Down
2 changes: 1 addition & 1 deletion lib/spack/spack/test/git_fetch.py
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ def test_git_sparse_paths_partial_clone(
for p in sparse_paths:
assert os.path.isdir(p)

if git_version < Version("2.25.0.0"):
if git_version < Version("2.26.0.0"):
# older versions of git should fall back to a full clone
for p in omitted_paths:
assert os.path.isdir(p)
Expand Down

0 comments on commit 8590595

Please sign in to comment.