Added fade effect to tabulation (Closes #88) #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not really convinced .. effect should appear to tab too (not only content), what you guys think ? |
|
not sure about fading the whole tab content... maybe we need a more prominent effect on the tab head... e.g. bounce |
|
let's merge this to have feedback, we'll revert if bad feedback |
pborreli
added a commit
that referenced
this pull request
Jan 22, 2014
Added fade effect to tabulation (Closes #88)
|
deployed |
|
My initial concern was, that we should promote the creation of new tabs. A effect when switching the active tab is not necessary IMO |
|
ah sorry, my mistake |
|
maybe we could find a nice way here http://daneden.github.io/animate.css/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.