New version of all of rails (5.2.4) broke the build

[depfu]

We've tested your project with an updated dependency and the build failed.

This version is either within the version range you specified or you haven't specified a version/range. To be able to test your project with the new version, we've taken the liberty of pinning the version for this branch and pull request.

name	version specification	new version
activesupport	>= 3.2	5.2.4

Unfortunately, we encountered failing tests after pinning. This means that this new version is not compatible with your project and the test failure will potentially also happen on fresh installs.

If you have correctly specified a semantic versioning version range, you should probably also file an issue with the upstream project as they might have released an update that's breaking SemVer rules, which is not cool. (But then again, not all projects explicitly follow SemVer)

We've left the pull request open for you to investigate this issue. Please don't merge it as is, because, again, we've pinned the version of activesupport for this test run.

What changed?

✳️ activesupport (>= 3.2 → 5.2.4) · Repo · Changelog

Release Notes

5.2.4

Active Support

• Make ActiveSupport::Logger Fiber-safe. Fixes #36752.

  Use Fiber.current.__id__ in ActiveSupport::Logger#local_level= in order
  to make log level local to Ruby Fibers in addition to Threads.

  Example:

  logger = ActiveSupport::Logger.new(STDOUT)
  logger.level = 1
  p "Main is debug? #{logger.debug?}"
  Fiber.new {
  
  logger.local_level = 0
  
  p "Thread is debug? #{logger.debug?}"
  
  }.resume
  p "Main is debug? #{logger.debug?}"
  
  

  Before:

  Main is debug? false
  Thread is debug? true
  Main is debug? true
  

  After:

  Main is debug? false
  Thread is debug? true
  Main is debug? false
  

  Alexander Varnin

Active Model

• Type cast falsy boolean symbols on boolean attribute as false.

  Fixes #35676.

  Ryuta Kamizono

Active Record

• Fix circular autosave: true causes invalid records to be saved.

  Prior to the fix, when there was a circular series of autosave: true
  associations, the callback for a has_many association was run while
  another instance of the same callback on the same association hadn't
  finished running. When control returned to the first instance of the
  callback, the instance variable had changed, and subsequent associated
  records weren't saved correctly. Specifically, the ID field for the
  belongs_to corresponding to the has_many was nil.

  Fixes #28080.

  Larry Reid

• PostgreSQL: Fix GROUP BY with ORDER BY virtual count attribute.

  Fixes #36022.

  Ryuta Kamizono

• Fix sqlite3 collation parsing when using decimal columns.

  Martin R. Schuster

• Make ActiveRecord ConnectionPool.connections method thread-safe.

  Fixes #36465.

  Jeff Doering

• Assign all attributes before calling build to ensure the child record is visible in
  before_add and after_add callbacks for has_many :through associations.

  Fixes #33249.

  Ryan H. Kerr

Action View

• Allow programmatic click events to trigger Rails UJS click handlers.
  Programmatic click events (eg. ones generated by Rails.fire(link, "click")) don't specify a button. These events were being incorrectly stopped by code meant to ignore scroll wheel and right clicks introduced in #34573.

  Sudara Williams

Action Pack

• No changes.

Active Job

• No changes.

Action Mailer

• No changes.

Action Cable

• No changes.

Active Storage

• No changes.

Railties

• Use original bundler environment variables during the process of generating a new rails project.

  Marco Costa

• Allow loading seeds without ActiveJob.

  Fixes #35782

  Jeremy Weathers

• Only force :async ActiveJob adapter to :inline during seeding.

  BatedUrGonnaDie

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 8 commits:

• Preparing for 5.2.4 release
• Preparing for 5.2.4.rc1 release
• dup instead of `@+` since we still support Ruby 2.2
• Merge pull request #37303 from eregon/follow-frozen-symbol-to_s
• Merge pull request #35121 from utilum/warning_tried_to_create_proc_without_block
• Merge pull request #36753 from cmrd-senya/36752-make-rails-logger-fiber-safe
• Merge pull request #36470 from lucasprag/activesupport/missing-require-digest
• Backport changes for Buildkite builds

---

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@​depfu rebase

Rebases against your default branch and redoes this update

@​depfu merge

Merges this PR once your tests are passing and conflicts are resolved

@​depfu close

Closes this PR and deletes the branch

@​depfu reopen

Restores the branch and reopens this PR (if it's closed)

@​depfu pause

Ignores all future updates for this dependency and closes this PR

@​depfu pause [minor|major]

Ignores all future minor/major updates for this dependency and closes this PR

@​depfu resume

Future versions of this dependency will create PRs again (leaves this PR as is)

[depfu]

Closed in favor of #28.