Refactor code to use http.RoundTripper #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only a "few" years late... The project that used this had already moved on by time you made the PR, so I missed it! but I'm dusting off this project and going to use it again for some new stuff, so better late then never! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies harhar pretty substantially such that it focuses on the http.RoundTripper interface, which is what http.Client uses internally. This lets it be used with existing applications without changing anything by the Transport property of the client.
In the interest of trying to avoid creating another HAR library in golang (there are several), I'd be happy to consolidate efforts. I understand this is a pretty large departure from your approach and happy to change the name of my fork if you'd prefer not to.