#2 implementation of identity map

pbgnz · Mar 29, 2021 · 41e4b37 · 41e4b37
1 parent 8d201b6
commit 41e4b37
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 18 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "random-quote-api",
-  "version": "1.1.1",
+  "version": "1.2.1",
   "description": "get random quotes",
   "main": "server.js",
   "scripts": {

diff --git a/server.js b/server.js
@@ -9,25 +9,34 @@ const port = process.env.PORT || 8000;
 app.use(express.json());
 app.use(router);
 
+let identityMap = new Map();
+
 router.get('/api/quotes', (req, res) => {
     let pageNumber = Math.floor(Math.random() * 100) + 1;
-    let quotes = [];
-    request('https://www.goodreads.com/quotes?page=' + pageNumber, function (err, r, body) {
-        if (err) {
-            res.send("401: Error getting quotes");
-        } else {
-            let $ = cheerio.load(body);
-            $('div.quoteText').each(function (index) {
-                const quote = $(this)[0].children[0].data.replace(/(\r\n|\n|\r| +(?= )| “|”)/gm, "");
-                const id = index;
-                quotes.push({ quote, id });
-            });
-            $('span.authorOrTitle').each(function (index) {
-                quotes[index].author = $(this)[0].children[0].data.replace(/(\r\n|\n|\r| +(?= )|,)/gm, "");
-            });
-            res.send({ quotes });
-        }
-    });
+
+    if (identityMap.has(pageNumber)) {
+        const quotes = identityMap.get(pageNumber);
+        res.send({ quotes });
+    } else {
+        let quotes = [];
+        request('https://www.goodreads.com/quotes?page=' + pageNumber, function (err, r, body) {
+            if (err) {
+                res.send("401: Error getting quotes");
+            } else {
+                let $ = cheerio.load(body);
+                $('div.quoteText').each(function (index) {
+                    const quote = $(this)[0].children[0].data.replace(/(\r\n|\n|\r| +(?= )| “|”)/gm, "");
+                    const id = index;
+                    quotes.push({ quote, id });
+                });
+                $('span.authorOrTitle').each(function (index) {
+                    quotes[index].author = $(this)[0].children[0].data.replace(/(\r\n|\n|\r| +(?= )|,)/gm, "");
+                });
+                identityMap.set(pageNumber, quotes);
+                res.send({ quotes });
+            }
+        });
+    }
 });
 
 app.listen(port);