[misc] make custom definition of DEVPKEY_Device_BusReportedDeviceDesc static#108
Closed
geovie wants to merge 1 commit intopbatard:masterfrom
Closed
[misc] make custom definition of DEVPKEY_Device_BusReportedDeviceDesc static#108geovie wants to merge 1 commit intopbatard:masterfrom
geovie wants to merge 1 commit intopbatard:masterfrom
Conversation
… static * prevents '_DEVPKEY_Device_BusReportedDeviceDesc already defined' linker error in user code
Owner
|
I don't mind applying this patch, but can you tell what toolchain you are using so I can try to replicate the issue? Is it VS2017? MinGW? Something else? |
Contributor
Author
|
I'm using VS2017 toolchain |
Contributor
Author
|
Testcase to replicate the issue. Change the LIBWDIPATH in PropertySheet.props before building. Without the change from this PR the linking will fail, with the change it will succeed |
Owner
|
Applied! Apologies for the delay and many thanks for the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When linking against some windows libraries (SetupApi.lib probably) i get the following linker error:
_DEVPKEY_Device_BusReportedDeviceDesc already defined.By making the custom definition in libwdi static the user can link against windows libraries without having duplicate symbols.