wdi-simple interface 0x00 and RSA 4096 bits#104
Closed
turboj wants to merge 4 commits intopbatard:masterfrom
Closed
wdi-simple interface 0x00 and RSA 4096 bits#104turboj wants to merge 4 commits intopbatard:masterfrom
turboj wants to merge 4 commits intopbatard:masterfrom
Conversation
Zadic now allows interface 00 from command line for a composite device
Change the generated RSA key size to 4096 bits and also document how key size is in upper 16 bits Note: RSA key size of 4096 is currently recommended for strong encryption
Both base device and the first composite interface can have interface number 0 (zero). Added an addional check for is_composite, otherwise driver installation fails.
Owner
|
Applied. Apologies for the extended delay... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wdi-simple had a similar bug like zadic with interface 0x00 - it would select the base usb devices instead of the correct interface.
Changed RSA key size to 4096 bits and documented the magic number creation.
Since key is auto-generated and never stored this should not be a security issue - but I think MS could disable 1024 bit keys alltogether at some point because they can be factored.
I also did not like the magic number that had no obvious reference to key size unless one is very fluent with hex calculations and bit shifts.