Skip to content

Commit

Permalink
fix(release): use git push --atomic
Browse files Browse the repository at this point in the history
That way it won't leave the repo in an inconsistent state.

It is supported by GitHub[1].

[1]: https://github.blog/2015-04-30-git-2-4-atomic-pushes-push-to-deploy-and-more/

(cherry picked from commit 40493de)

Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
  • Loading branch information
pb8o committed Dec 6, 2023
1 parent 31297ed commit f36a3db
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tools/release-tag.sh
Original file line number Diff line number Diff line change
Expand Up @@ -61,5 +61,5 @@ warn "!WARNING! The next step will modify upstream: $UPSTREAM_URL by running:"
echo " git push $UPSTREAM v$version"
echo " git push $UPSTREAM $RELEASE_BRANCH"
get_user_confirmation || die "Cancelling tag push"
git push $UPSTREAM "v$version"
git push $UPSTREAM "$RELEASE_BRANCH"
git push --atomic $UPSTREAM "v$version"
git push --atomic $UPSTREAM "$RELEASE_BRANCH"

0 comments on commit f36a3db

Please sign in to comment.