Address #511 #514
Merged
Address #511 #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`BundleInlineRefs` was not operating correctly, it got refactored out of use. Added some docs and clarification, and resolved the bundler behavior
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #514 +/- ##
========================================
Coverage 99.50% 99.51%
========================================
Files 190 191 +1
Lines 23013 23403 +390
========================================
+ Hits 22900 23290 +390
Misses 68 68
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ensure we hit the defensive check
Now we can track the origins of all the references from the composed bundled doc.
When using a custom file system, some relative paths were being doubled up in certain scenarios when files link backwards and forwards. Updated a lot of places where this can occurr as it appeared during stress testing of an upsrream feature using the rolodex with a custom file system. We now check for overlap consistently and resolve properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.