Feature/bdh-5/deck #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect and script 2:05 of https://youtu.be/riafP7MtvmQ?si=IrNjwHy4YW2-ShC2 next: raycast so deck can see click, create interaction/input manager
pb-413
commented
Feb 22, 2025
project/Scripts/InputManager.gd
Outdated
| emit_signal("left_mouse_button_released") | ||
|
|
||
|
|
||
| func racast_at_cursor(): |
|
|
||
|
|
||
| func add_card_to_hand(card): | ||
| func add_card_to_hand(card, speed=DEFAULT_CARD_MOVE_SPEED): |
Owner
Author
There was a problem hiding this comment.
Deck.gb adds at a different speed (draw_card), so this function correctly has a new parameter with a default constant. We take advantage of the default in finish_drag when we return a card to hand.
|
|
||
|
|
||
| func update_hand_positions(): | ||
| func update_hand_positions(speed=DEFAULT_CARD_MOVE_SPEED): |
Owner
Author
There was a problem hiding this comment.
In one place we pass a new speed (see add_card_to_hand()) and in another we take advantage of the default: remove_card_from_hand.
|
|
||
|
|
||
| func animate_card_to_position(card, new_position): | ||
| func animate_card_to_position(card, new_position, speed=DEFAULT_CARD_MOVE_SPEED): |
Owner
Author
There was a problem hiding this comment.
We never take advantage of this default because the functions (add_card_to_hand and update_hand_positions) that call this function, animate_card_to_position, also take a speed.
Should this function not have a default? Adding a code comment to this effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for DECK - Godot 4.3 Card Game Tutorial #5 episode of Barry's Development Hell Card Game Tutorial Series