Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Symfony 5.4 #3

Merged
merged 52 commits into from
Mar 15, 2024

Conversation

maruf-paysera
Copy link
Contributor

Summary

This MR:

  1. adds support to Symfony 5.4
  2. Drop support for old php versions (below php 5.5)
  3. Drop support for old Symfony versions (backward compatibility with old Symfony versions is not possible due to symfony changed the authentication mechanism since version 5)

Test

  1. ./vendor/bin/phpunit

@maruf-paysera
Copy link
Contributor Author

@mSprunskas please review

src/Security/BearerPassportAuthenticator.php Outdated Show resolved Hide resolved
src/Security/BearerPassportAuthenticator.php Outdated Show resolved Hide resolved
src/Listener/BearerListener.php Outdated Show resolved Hide resolved
Copy link
Contributor

@mSprunskas mSprunskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not work on sf 4, please test code on both sf4 and sf5

src/PayseraBearerAuthenticationBundle.php Outdated Show resolved Hide resolved
src/Listener/BearerListener.php Outdated Show resolved Hide resolved
src/DependencyInjection/Security/Factory/BearerFactory.php Outdated Show resolved Hide resolved
src/Security/Token/BearerTokenInterface.php Outdated Show resolved Hide resolved
src/Security/Provider/BearerProvider.php Show resolved Hide resolved
src/Security/Provider/BearerProvider.php Outdated Show resolved Hide resolved
src/Security/Voter/BearerVoter.php Outdated Show resolved Hide resolved
src/Security/BearerPassportAuthenticator.php Outdated Show resolved Hide resolved
src/Resources/config/services/security.xml Outdated Show resolved Hide resolved
@maruf-paysera
Copy link
Contributor Author

Does not work on sf 4, please test code on both sf4 and sf5

@mSprunskas tested on both sf4 and sf5, works as expected

README.md Show resolved Hide resolved
@mSprunskas mSprunskas merged commit 7bb352f into paysera:master Mar 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants