Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style/RedundantDoubleSplatHashBraces-20240103233325 #11

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Style/RedundantDoubleSplatHashBraces-20240103233325 #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2322c56
:police_car: regenerate rubocop todo
Jan 3, 2024
5246a26
:police_car: Style/RedundantDoubleSplatHashBraces
Jan 3, 2024
a473c8f
:police_car: regenerate rubocop todo
Jan 3, 2024
0e83dda
Merge branch 'master' into rubocop-challenge/20240103233325
mathieujobin Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions .rubocop_todo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,14 +172,13 @@ Layout/SpaceInsideBlockBraces:
- 'lib/excel_templating/document/data_source_registry.rb'
- 'spec/excel_abstraction/cell_reference_spec.rb'

# Offense count: 38
# Offense count: 36
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
# SupportedStyles: space, no_space, compact
# SupportedStylesForEmptyBraces: space, no_space
Layout/SpaceInsideHashLiteralBraces:
Exclude:
- 'lib/excel_templating/excel_abstraction/sheet.rb'
- 'spec/column_validation_spec.rb'
- 'spec/excel_abstraction/cell_range_spec.rb'
- 'spec/excel_abstraction/cell_spec.rb'
Expand Down Expand Up @@ -555,12 +554,6 @@ Style/RaiseArgs:
- 'lib/excel_templating/excel_abstraction/active_cell_reference.rb'
- 'lib/excel_templating/excel_abstraction/cell.rb'

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
Style/RedundantDoubleSplatHashBraces:
Exclude:
- 'lib/excel_templating/excel_abstraction/sheet.rb'

# Offense count: 2
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: SafeForConstants.
Expand Down
2 changes: 1 addition & 1 deletion lib/excel_templating/excel_abstraction/sheet.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ def initialize(sheet, workbook)
end

def header(value, **options)
cell(value, **{bold: 1}.merge(options))
cell(value, bold: 1, **options)
self
end

Expand Down
Loading