Refactor paypal provider #711
Conversation
|
| type: INSTANCE_DISPATCH_ACTION.RESET_STATE, | ||
| value: INSTANCE_LOADING_STATE.SDK_LOADED, | ||
| }); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
There was a problem hiding this comment.
I think we should turn what's missing here into refs rather than ignore the deps array.
There was a problem hiding this comment.
Would that mean keeping the sdkInstance in a ref AND in state? Would that open us up to issues if the instances aren't the same/managed?
| type: INSTANCE_DISPATCH_ACTION.SET_LOADING_STATUS, | ||
| value: INSTANCE_LOADING_STATE.SDK_LOADED, | ||
| }); | ||
| } catch (error) { |
…l/paypal-js into feature/refactor-paypal-provider
| }, [memoizedScriptOptions]); // Only reset when script options change | ||
|
|
||
| // SDK loading effect - only runs on client (useEffect doesn't run during SSR) | ||
| useEffect(() => { |
There was a problem hiding this comment.
I think this useEffect might conflict with the useEffect on line 99. Also, having this dispatch separate from the createInstance call feels incorrect, as in, I think we should have this dispatch occur in the same effect as the create call.
|
Closing this PR in favor of the changes here which include some of the updates that have been demonstrated here. |
No description provided.