Feat: Upgrade Typescript to v5 in react-paypal-js #685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 67ab7c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
EvanReinstein
changed the base branch from
main
to
feature/react-paypal-js-v6
…emove rollup force install in github workflows
… typescript upgrade
kand
approved these changes
Sep 23, 2025
gregjopa
reviewed
Sep 23, 2025
gregjopa
approved these changes
Sep 23, 2025
EvanReinstein
added a commit
that referenced
this pull request
Oct 1, 2025
* initial package.json and rollup updates, changes tsconfig to bundler and adds v6 specific tsconfig * upgrade react-paypal-js typescript package to v5.3.3 * update tsconfig for v6 namespace * chore: add changeset * align rollup version and update playwright yml * change playwright.yml download deps command * update actions checkout and setup-node to v4 * update .nvmrc * try different method for installing dependencies * fix package dependency issues related to rollup and terser * revert change to download deps step * update package-lock * test fix for rollup option deps bug * update build script * test adding cache to setup node action, update install command, and remove rollup force install in github workflows * re-add force rollup install in github workflows * run npm install to update package-lock with new package versions from typescript upgrade * revert changes to download deps and setup node steps in github workflows * install with update to package.json * leverage fresh package-lock and remove all artifactory package resolution paths * fix check annotations warnings * add new line at the end of gitignore
EvanReinstein
added a commit
that referenced
this pull request
Oct 7, 2025
* Feat: Upgrade Typescript to v5 in react-paypal-js (#685) * initial package.json and rollup updates, changes tsconfig to bundler and adds v6 specific tsconfig * upgrade react-paypal-js typescript package to v5.3.3 * update tsconfig for v6 namespace * chore: add changeset * align rollup version and update playwright yml * change playwright.yml download deps command * update actions checkout and setup-node to v4 * update .nvmrc * try different method for installing dependencies * fix package dependency issues related to rollup and terser * revert change to download deps step * update package-lock * test fix for rollup option deps bug * update build script * test adding cache to setup node action, update install command, and remove rollup force install in github workflows * re-add force rollup install in github workflows * run npm install to update package-lock with new package versions from typescript upgrade * revert changes to download deps and setup node steps in github workflows * install with update to package.json * leverage fresh package-lock and remove all artifactory package resolution paths * fix check annotations warnings * add new line at the end of gitignore * add ssr checks to load core sdk script func and add initial instance provider * add a basic set of hooks * update exports * mark usePayPalInstance hook as exportable * add isServer util and apply where appropriate * clean up usePayPalInstance file * update exports * create v6 specific utils file * add reducer to manage various state, fix missed isServer condition in paypal-js * update paypal sdk instance provider name * remove json.stringify operation from memoizedOptions * clean up useMemo * clean up useMemo import * update provider to account for useEffect during ssr * add tests for client-side and server-side instance provider * add instance provider context test * add context test and clean up other provider tests * update initial to pending state useEffect with empty dependency array * configure provider to handle memoization of create instance and script options * memoize context to prevent rerenders * remove duplicate isServer * swap deep equality check packages * update isServer to a function that also checks whether the document is present * fix tests and missed isServer uses * remove isServer from eligibility useEffect * add changeset * add ref for initial hydration * remove abort controller * flatten create instance options props object * update naming convention * update tests to reflect name and prop passing changes * remove dead code isServer check * update jsdoc * update imports to correct values * add console warning to loadCoreSdkScript * remove create instance and script options from reducer state * remove sdkInstance check in loading useEffect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aligns the version of Typescript used in
react-paypal-jswithpaypal-js, both are now usingv5.3.3. This change also includes initial updates to preparereact-paypal-jsfor development of PayPal V6 JS SDK.