Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#287] fileTypes.html not producing correct results #288

Merged
merged 1 commit into from
Oct 22, 2019

Conversation

pjeli
Copy link
Collaborator

@pjeli pjeli commented Oct 22, 2019

Make sure you have checked all steps below.

GitHub Issue

Fixes #

Checklist:

  • This pull request updates the documentation
  • This pull request changes the code
  • Title of the PR is of format (example) : [#25] Add Pull Request Template, where [#25] is the GitHub issue number

What is the purpose of this pull request?

How was this change validated?

Commit Guidelines

  • My commits all reference GH issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #288 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #288      +/-   ##
============================================
- Coverage     74.34%   74.32%   -0.02%     
+ Complexity     1042     1041       -1     
============================================
  Files            52       52              
  Lines          6934     6934              
  Branches        618      618              
============================================
- Hits           5155     5154       -1     
  Misses         1398     1398              
- Partials        381      382       +1
Impacted Files Coverage Δ Complexity Δ
...doop/hdfs/server/namenode/AbstractQueryEngine.java 67.06% <0%> (-0.2%) 204% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 659dfca...654aa3a. Read the comment docs.

@pjeli pjeli merged commit 0746448 into paypal:master Oct 22, 2019
@pjeli pjeli deleted the issue-287 branch October 22, 2019 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant