fix(next): passes doc through edit view handler #9302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobsfletch
changed the title
jacobsfletch
changed the title
|
🚀 This is included in version v3.0.0-beta.135 |
kendelljoseph
pushed a commit
that referenced
this pull request
Feb 21, 2025
The Edit and Live Preview views were duplicately making the same Local API requests for document data. This is because while the top-level document view handler makes these requests _before_ rendering the Live Preview view, it wasn't passing it's data through as props. This has also led to inconsistencies in the options being passed through the requests themselves, such as `locale`, `user`, and `overrideAccess: false`. Everything is now standardized as expected through the existing `getDocumentData` utility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Edit and Live Preview views were duplicately making the same Local API requests for document data. This is because while the top-level document view handler makes these requests before rendering the Live Preview view, it wasn't passing it's data through as props. This has also led to inconsistencies in the options being passed through the requests themselves, such as
locale,user, andoverrideAccess: false. Everything is now standardized as expected through the existinggetDocumentDatautility.