fix: getPayload node exits on webpack-hmr websocket failure #9279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 This is included in version v3.0.0-beta.135 |
kendelljoseph
pushed a commit
that referenced
this pull request
Feb 21, 2025
### What? When a script attempts to load payload using `getPayload()`, it will end with: `Error: connect ECONNREFUSED 127.0.0.1:3000` etc... ### Why? Even though there is a try/catch, it still errors because WebSocket connection failures happen asynchronously after the ws object is instantiated. ### How? Added the error handling function cached.ws.onerror to prevent exit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When a script attempts to load payload using
getPayload(), it will end with:Error: connect ECONNREFUSED 127.0.0.1:3000etc...Why?
Even though there is a try/catch, it still errors because WebSocket connection failures happen asynchronously after the ws object is instantiated.
How?
Added the error handling function cached.ws.onerror to prevent exit.