Repository navigation
Conversation
Nothing in the package imports find-node-modules. It still pulled findup-sync, micromatch and braces into every app that uses a @payloadcms/storage-* adapter, which `npm audit` reports as GHSA-vfj7-8cjw-p6xm. Remove it and its @types package.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes the
find-node-modulesdependency and its@types/find-node-modulesdev dependency from@payloadcms/plugin-cloud-storage.Why?
Nothing in the repo imports
find-node-modules. A search of the source finds it only in this package'spackage.json, so it does nothing at runtime. It still gets installed for every app that uses a@payloadcms/storage-*adapter, and it pulls infindup-sync,micromatchandbraces, whichnpm auditflags as GHSA-vfj7-8cjw-p6xm. Users can't fix that with overrides, as described in the issue.How?
packages/plugin-cloud-storage/package.json.pnpm-lock.yamlwith the repo's pinned pnpm (11.9.0). The lockfile change is only removals (about 100 lines), coveringfind-node-modulesand the packages that only it needed (findup-sync,detect-file,expand-tilde,global-modules,global-prefix,homedir-polyfill,is-windows,merge,parse-passwd,resolve-dir). Nothing was added or upgraded.I checked that
pnpm install --lockfile-only --frozen-lockfilepasses on the result. I did not run a full build.The issue reports this on 3.90.2, so a 3.x backport would be the same two-line change, and I can open that too if you want it.
Fixes #18623