Repository navigation
fix: strip EXIF metadata when withMetadata is false without explicit adjustments (#18629) - #18630
Open
PINYOPATTANAWASANPORN wants to merge 1 commit into
Conversation
…e without explicit image adjustments (payloadcms#18629)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
esizeOptions, ormatOptions, rimOptions, constructorOptions) are still passed through Sharp's transformation pipeline (
otate() + optionallyAppendMetadata()) rather than early-returning { status: 'continue' } with raw unaltered buffers.
Root Cause / Technical Context
Fixes #18629.
When an upload collection specifies withMetadata: false without resizing or format conversions, ransformMain in packages/transformer-sharp/src/transformFile.ts previously bypassed Sharp completely via:
ypescript if (!fileIsAnimatedType && !fileHasAdjustments) { return { status: 'continue' } }This caused the unmodified uploaded buffer to be written directly to storage, preserving raw EXIF metadata (GPS geographic coordinates, camera device info, timestamps). Checking withMetadata !== false ensures that collections configured to strip metadata correctly invoke Sharp to produce sanitized file buffers.
Verification & Testing
Impact & Compatibility