Repository navigation
Conversation
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖 |
jacobsfletch
reviewed
Oct 8, 2026
| ...config, | ||
| routes: { | ||
| ...config.routes, | ||
| api: '/custom-api', |
Member
There was a problem hiding this comment.
Shouldn't this just be written directly into the Payload config? Let's also move this custom route setup to the test dir. The root app dirs here are meant to be unmodified sources of truth.
jacobsfletch
reviewed
Oct 8, 2026
| ], | ||
| endpoints: [ | ||
| { | ||
| handler: ({ payload }) => { |
Member
There was a problem hiding this comment.
This is a very strange way to test this. Let's reuse the existing endpoints suite instead, and define the routes.api directly on the Payload config (this will affect all api routes in this suite but that's fine). It will need its own app and app-tanstack dirs to define the custom api path. This will isolate the change to this one suite.
r1tsuu
marked this pull request as draft
October 9, 2026 12:59
r1tsuu
marked this pull request as ready for review
October 9, 2026 13:05
jacobsfletch
approved these changes
Oct 9, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes TanStack Start REST requests returning 404 when
routes.apiis customized.The TanStack handler now passes the request pathname directly to Payload instead of rebuilding it with a hard-coded
/apiprefix. In Next.js, the endpoint path is constructed usingconfig.routes.api.Testing
routes.apito/custom-apiin theendpointstest suite config, so its existing int tests run under a custom API route.test/endpoints/tanstack.int.spec.ts, which calls the TanStackhandleAPIRoutehandler with a request under the custom API route and verifies it resolves (fails with 404 without the fix).