fix(next): conditionally query snapshot field based on localization#15693
Draft
fix(next): conditionally query snapshot field based on localization#15693
Conversation
The snapshot field only exists in version schemas when localization is enabled. The Versions view was unconditionally querying this field, causing "path cannot be queried: snapshot" errors for collections without localization (e.g., trash tests). This aligns with the existing pattern at lines 53-59 in the same file.
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a query validation error in the Versions view that occurs when viewing versions for collections without localization enabled.
Key Changes
Made the
snapshotquery conditional on localization infetchLatestVersioncallssnapshotfield only exists in version schemas whenconfig.localizationis enabledAligns with the existing pattern already used earlier in the same file (lines 53-59) for the main versions query
Design Decisions
The fix follows the existing pattern in the same file where the
snapshotfilter is conditionally applied:The two
fetchLatestVersioncalls forcurrentlyPublishedVersionandlatestDraftVersionwere missing this guard, causing failures when localization is disabled.When localization is disabled, no snapshot versions exist anyway, so the filter is unnecessary.