fix(richtext-lexical): use headingLevel in danish heading label#15685
Open
divyesh123-jain wants to merge 3 commits intopayloadcms:mainfrom
Open
fix(richtext-lexical): use headingLevel in danish heading label#15685divyesh123-jain wants to merge 3 commits intopayloadcms:mainfrom
divyesh123-jain wants to merge 3 commits intopayloadcms:mainfrom
Conversation
Fixes infinite redirect loop on 404 routes in production builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Danish rich text heading labels now show "Overskrift 1", "Overskrift 2", etc. instead of the raw placeholder "Overskrift {{overskriftNi...".
Why?
With the UI in Danish, the heading dropdown (H1–H4) showed an unresolved placeholder because the Danish string used
{{overskriftNiveau}}while the code only passesheadingLevel. The interpolation key must be{{headingLevel}}for the value to be substituted.How?
In
packages/richtext-lexical/src/features/heading/server/i18n.ts, the Danish (da) label was changed from'Overskrift {{overskriftNiveau}}'to'Overskrift {{headingLevel}}'so it matches the variable passed by the client. No other locales used a different placeholder.