fix: preserve locale data in unnamed groups with localizeStatus#15658
Draft
JarrodMFlesch wants to merge 5 commits intomainfrom
Draft
fix: preserve locale data in unnamed groups with localizeStatus#15658JarrodMFlesch wants to merge 5 commits intomainfrom
JarrodMFlesch wants to merge 5 commits intomainfrom
Conversation
…bles Pass original docWithLocales to recursive calls for pass-through fields (unnamed groups, unnamed tabs, rows, collapsibles) to preserve locale data. Extract only the specific field names belonging to each layout field when merging results back to avoid overwriting already-processed fields. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a localized publishing data-loss bug in mergeLocalizedData() when traversing pass-through / layout-only fields (unnamed groups, rows, collapsibles, unnamed tabs), which could previously overwrite already-merged locale data.
Changes:
- Add
collectFlattenedFieldNames()and use it to selectively copy only the affected keys after recursing through pass-through fields. - Update recursion for pass-through/layout-only fields to use the original
docWithLocales(and avoidObject.assign-style overwrites). - Add unit/regression tests covering unnamed groups, row fields, and unnamed tabs for locale preservation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/payload/src/utilities/mergeLocalizedData.ts | Prevents stale overwrite when merging through pass-through fields by selectively copying only relevant keys. |
| packages/payload/src/utilities/mergeLocalizedData.spec.ts | Adds regression tests reproducing #15642 and covering related pass-through layouts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
localizeStatus: truemergeLocalizedData()was incorrectly processing pass-through/layout-only fieldsTechnical Details
The bug occurred because pass-through fields (unnamed groups, rows, collapsibles, unnamed tabs) used
Object.assign(result, merged)after recursive calls, which would overwrite already-processed fields with stale data.The fix:
collectFlattenedFieldNames()helper to extract field names belonging to a layout fielddocWithLocalesto recursive calls (notresult)Test plan
Fixes #15642