fix: prevent req.file leak between sequential duplicate() calls on upload collections#15620
Open
jhb-dev wants to merge 1 commit intopayloadcms:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Prevents
req.filefrom leaking between sequentialpayload.duplicate()calls when a sharedreqobject is used for upload collections.Why?
When calling
payload.duplicate()multiple times on the samereqobject (e.g. in batch operations within a transaction), only the first document's file was used for all subsequent duplications.generateFileDatawrites the processed file back toreq.file, and on the next calllet file = req.filewas truthy, so the block that fetches the correct source file from storage was skipped entirely.How?
When
isDuplicatingis true,req.fileis now ignored so the source file is always fetched fresh from storage for each duplicate operation. This is a one-line change ingenerateFileData.ts:An integration test was added that creates two upload documents with different files, duplicates both using a shared
req, and asserts each duplicate derives its filename from the correct source document.Fixes #15619