fix(ui): use consistent empty state styling between list and folder views#15555
Open
AhmadYasser1 wants to merge 1 commit intopayloadcms:mainfrom
Open
fix(ui): use consistent empty state styling between list and folder views#15555AhmadYasser1 wants to merge 1 commit intopayloadcms:mainfrom
AhmadYasser1 wants to merge 1 commit intopayloadcms:mainfrom
Conversation
…iews Replaces the inline no-results div in the list view with the shared NoListResults component already used by folder and browse-by-folder views. This ensures both views render the same centered, bordered empty state container when a collection has no documents. Removes the now-unused .collection-list__no-results SCSS block and updates e2e test selectors to match the new .no-results class name. Fixes payloadcms#15524
AhmadYasser1
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Uses the shared
NoListResultscomponent in the list view empty state, matching the styling already used by the folder and browse-by-folder views.Why?
The empty state for the list view (left-aligned, no border) looks completely different from the folder view empty state (centered, dashed border). This inconsistency was reported in #15524.
How?
collection-list__no-resultsdiv inDefaultListViewwith the existingNoListResultscomponent fromelements/NoListResults&__no-resultsSCSS block fromList/index.scss.collection-list__no-resultsto.no-resultsFixes #15524