-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix(ui): password fields disappear after server-side validation fails #15092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PatrikKozak
wants to merge
5
commits into
main
Choose a base branch
from
fix/password-fields-disappearing-on-validation-error
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(ui): password fields disappear after server-side validation fails #15092
PatrikKozak
wants to merge
5
commits into
main
from
fix/password-fields-disappearing-on-validation-error
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sword fields visible
…d-fields-disappearing-on-validation-error
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Password fields disappear after server-side validation fails when using custom
beforeValidatehooks.Why
Two issues:
setModified(false)was called before checking response status, causing the Auth component to hide password fieldsAfter
ADD_SERVER_ERRORSadded validation errors, the form state change triggeredonChange, which fetched fresh state from the server using only client-side validation. This overwrote the custom server errors viaMERGE_SERVER_STATEHow
Only call
setModified(false)on successful submissions (status < 400)Track when server errors are added with
serverErrorsJustAddedRefSkip the immediate
onChangeafter server errors if only error state changed (usingisOnlyErrorStateChangehelper)Allow
onChangeto proceed normally if user actually modified field valuesFixes #14858