fix(ui): avoid creating hasMany options during IME composition #15086
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
\### What? Prevents hasMany text fields from creating new items when Enter/Tab is pressed while IME composition is active. \### Why? IME users were unintentionally adding multiple items because composition key events were treated as submit actions. \### How? - Check `event.nativeEvent.isComposing` in `packages/ui/src/elements/ReactSelect/index.tsx` before creating a new option. - Guard `packages/ui/src/fields/Text/Input.tsx` editable label key handling with `event.nativeEvent.isComposing` so Enter/Tab/Escape only finalize when not composing. Fixes payloadcms#12427
Robot-Inventor
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
JarrodMFlesch
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Prevents hasMany text fields from creating new items when Enter/Tab is
pressed while IME composition is active.
Why?
IME users were unintentionally adding multiple items because composition
key events were treated as submit actions.
How?
event.nativeEvent.isComposinginpackages/ui/src/elements/ReactSelect/index.tsxbefore creating a newoption.
packages/ui/src/fields/Text/Input.tsxeditable label keyhandling with
event.nativeEvent.isComposingso Enter/Tab/Escape onlyfinalize when not composing.
Fixes #12427