Skip to content

Add Pull Request Review Template#967

Merged
DanGould merged 1 commit intopayjoin:masterfrom
DanGould:pr-checklist
Aug 18, 2025
Merged

Add Pull Request Review Template#967
DanGould merged 1 commit intopayjoin:masterfrom
DanGould:pr-checklist

Conversation

@DanGould
Copy link
Contributor

Do some basic checks before requesting review, please.

Do some basic checks before requesting review, please.
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 17046473196

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.269%

Totals Coverage Status
Change from base Build 17045080947: 0.0%
Covered Lines: 7734
Relevant Lines: 8965

💛 - Coveralls

Copy link
Collaborator

@arminsabouri arminsabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack 5c499cf

@DanGould DanGould merged commit 4881119 into payjoin:master Aug 18, 2025
9 of 10 checks passed
@DanGould DanGould deleted the pr-checklist branch August 18, 2025 16:34
@benalleng
Copy link
Collaborator

missed opportunity for some em-dashes sprinked in

@spacebear21
Copy link
Collaborator

Unfortunately the template gets pulled into merge commit descriptions by default, and could easily end up spamming the git history

Screenshot 2025-08-18 at 16 38 59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants