Skip to content

Bump MSRV to 1.85.0#957

Merged
spacebear21 merged 1 commit intopayjoin:masterfrom
benalleng:msrv-1.85
Aug 15, 2025
Merged

Bump MSRV to 1.85.0#957
spacebear21 merged 1 commit intopayjoin:masterfrom
benalleng:msrv-1.85

Conversation

@benalleng
Copy link
Collaborator

@benalleng benalleng commented Aug 15, 2025

Closes #954

Following the rest of the ecosystem we are bumping rust-payjoin to an msrv of 1.85.0.

Any actual code changes / improvements beyond lint failures caused by the upgrade will come in a follow-up PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is now a lint failure to use the .repeat().take() syntax instead of .repeat_n() in 1.85.0

@coveralls
Copy link
Collaborator

coveralls commented Aug 15, 2025

Pull Request Test Coverage Report for Build 16993064022

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.314%

Totals Coverage Status
Change from base Build 16992425929: 0.0%
Covered Lines: 7726
Relevant Lines: 8951

💛 - Coveralls

@benalleng
Copy link
Collaborator Author

The nicely rendered README just to look through for easier review

@DanGould
Copy link
Contributor

A follow up is going to be figuring out what dependency versions actually still need to be pinned. They have certainly changed.

Following the rest of the ecosystem we are bumping rust-payjoin to an
msrv of 1.85.0.
Copy link
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reACK

@spacebear21 spacebear21 merged commit fffcf4d into payjoin:master Aug 15, 2025
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump MSRV to 1.85

4 participants