Skip to content

Reduce visibility of state transition types#955

Merged
DanGould merged 1 commit intopayjoin:masterfrom
arminsabouri:reduce-visibility-state-transition-objects
Aug 15, 2025
Merged

Reduce visibility of state transition types#955
DanGould merged 1 commit intopayjoin:masterfrom
arminsabouri:reduce-visibility-state-transition-objects

Conversation

@arminsabouri
Copy link
Collaborator

These inner types were pub(crate)'ed so tests can access the next state by passing persisting. However, using the noop persister can achieve the same thing while reducing boilerplate.

cc'ing @benalleng bc I think you originally contributed the tests I modified

These inner types were pub(crate)'ed so tests can access the next state
by passing persisting. However, using the noop persister can achieve the
same thing while reducing boilerplate.
@arminsabouri arminsabouri requested a review from benalleng August 13, 2025 23:35
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 16951875748

Details

  • 40 of 40 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 85.973%

Totals Coverage Status
Change from base Build 16943032439: 0.06%
Covered Lines: 7551
Relevant Lines: 8783

💛 - Coveralls

Copy link
Collaborator

@benalleng benalleng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uTack. Ahh nice improvement! I must have simply just not understood this was an ideal place for the session persister.

Copy link
Contributor

@DanGould DanGould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6316cbb

@DanGould DanGould merged commit 1d8e43b into payjoin:master Aug 15, 2025
10 checks passed
@arminsabouri arminsabouri deleted the reduce-visibility-state-transition-objects branch August 15, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants